deepset-ai
feat: Added JSONToDocument component in converter components
Related Issues
- fixes #7784
Proposed Changes:
I have added a JSONToDocument component in converter folder. This is a basic version of a JSON converter based on jq library.
How did you test it?
I have added three unit tests for a component designed to verify the functionality of converting JSON data into Document object. The first one checks if the JSONToDocument component can successfully process a JSON file while the others ensures that the component handles two different issues.
Checklist
- I have read the contributors guidelines and the code of conduct
- I have updated the related issue with new insights and changes
- I added unit tests and updated the docstrings
- I've used one of the conventional commit types for my PR title:
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:. - I documented my code
- I ran pre-commit hooks and fixed any issue
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
7 out of 9 committers have signed the CLA.
:white_check_mark: sjrl
:white_check_mark: nvzard
:white_check_mark: davidsbatista
:white_check_mark: shadeMe
:white_check_mark: dfokina
:white_check_mark: Amnah199
:white_check_mark: tradicio
:x: wochinge
:x: Tommaso Radicioni
Tommaso Radicioni seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
:wave:
quick comment about branches: you should target deepset-ai:main instead of deepset-ai:v2.3.x
👋 quick comment about branches: you should target
deepset-ai:maininstead ofdeepset-ai:v2.3.x
I should have changed target, thanks!
@tradicio Are you still working on this? If so, please rebase the PR on main (that'll probably sort out the CLA failures as well).
Closing this PR as it is currently stale and not ready for merge, with no further work being done. Issue #7784 remains open for future work.
