Pipeline run logic not robust with cyclic graphs

Open shadeMe opened this issue 1 year ago • 2 comments

Follow-up to https://github.com/deepset-ai/haystack/issues/7985, related to https://github.com/deepset-ai/haystack/issues/7960

The workaround that was added to "fix" the above issue only applies to pipeline graphs that are DAGs. As it currently stands, pipelines containing loops/cycles can cause components to misfire/fire more than once and/or launch in an indeterminate order.

Possible contributing factors

Support for default inputs.
Variadic (greedy) components.

Jul 15 '24 08:07 shadeMe

Experimental fix in https://github.com/deepset-ai/haystack/tree/subgraphs

Aug 27 '24 12:08 shadeMe

https://github.com/deepset-ai/haystack/pull/8431

Oct 18 '24 09:10 shadeMe

Solved by #8431.

Oct 29 '24 14:10 silvanocerza