haystack
haystack copied to clipboard
deepset-ai
feat: Add document page number of ExtractedAnswer to meta
Related Issues
- fixes #7570
Proposed Changes:
- Calculate document page number of ExtractedAnswer as in Haystack 1.x
- Add page number to ExtractedAnswer's meta data under the key
"answer_page_number" - Updated existing unit test
How did you test it?
~~tests are still missing~~ Ran all ExtractiveReader tests locally ~~we need to check whether the document's meta contains page number~~ https://github.com/deepset-ai/haystack/pull/7599 adds page numbers to meta
Notes for the reviewer
Checklist
- I have read the contributors guidelines and the code of conduct
- I have updated the related issue with new insights and changes
- I added unit tests and updated the docstrings
- I've used one of the conventional commit types for my PR title:
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:. - I documented my code
- I ran pre-commit hooks and fixed any issue
Pull Request Test Coverage Report for Build 8923598800
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- 6 unchanged lines in 1 file lost coverage.
- Overall coverage increased (+0.07%) to 90.203%
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| components/readers/extractive.py | 6 | 95.58% |
| <!-- | Total: | 6 |
| Totals | |
|---|---|
| Change from base Build 8881259484: | 0.07% |
| Covered Lines: | 6399 |
| Relevant Lines: | 7094 |
