haystack icon indicating copy to clipboard operation
haystack copied to clipboard

Port selected 1.x components to 2.x

Open julian-risch opened this issue 1 year ago • 4 comments

We identified the following key components from Haystack 1.x that still need to be ported to Haystack 2.0:

### Tasks
- [ ] https://github.com/deepset-ai/haystack-core-integrations/issues/645
- [ ] https://github.com/deepset-ai/haystack/issues/7367
- [x] https://github.com/deepset-ai/haystack/issues/7012
- [ ] https://github.com/deepset-ai/haystack/issues/7011
- [ ] https://github.com/deepset-ai/haystack/issues/7017
- [ ] https://github.com/deepset-ai/haystack/issues/5679
- [ ] https://github.com/deepset-ai/haystack/issues/6609

julian-risch avatar Jan 02 '24 11:01 julian-risch

Hey @julian-risch could we also add the nltk support for the DocumentSplitter in this list? That is a very common feature we are using right now in Haystack v1.

sjrl avatar Jan 02 '24 12:01 sjrl

And to clarify, is the TextClassifier in this list referring to the TransformersQueryClassifier from Haystack v1?

sjrl avatar Jan 02 '24 13:01 sjrl

@sjrl Yes, it's about porting TransformersQueryClassifier but could become two classes TransformersTextClassifier and TransformersDocumentClassifier. That would be consistent with the SentenceTransformersDocumentEmbedder and the SentenceTransformersTextEmbedder we have in 2.x. Should behave similar to https://github.com/deepset-ai/haystack/blob/main/haystack/components/classifiers/document_language_classifier.py

julian-risch avatar Feb 05 '24 10:02 julian-risch

@julian-risch thanks for the clarification! @bglearning might also be taking a look at porting the TransformersQueryClassifier, so tagging him here.

sjrl avatar Feb 05 '24 10:02 sjrl