haystack icon indicating copy to clipboard operation
haystack copied to clipboard

Refactor deactivated e2e tests and add to workflow

Open julian-risch opened this issue 2 years ago • 0 comments

ToDo:

  • Tests in e2e/modeling/test_adaptive_qa_inference.py can be removed and the asserts can be checked in a e2e test with a QAPipeline.

  • Tests in e2e/modeling/test_distillation.py can remain e2e tests, dataset contains just two samples

  • Tests in e2e/modeling/test_dpr.py do not mirror user behavior but tests are extensive, cover important parts of the code base and still run through. They are using tokenizers and embedding models thus no unit tests.

  • Tests in e2e/modeling/test_feature_extraction.py cover important parts of the code base, require models, could be part of one larger e2e test

  • Tests in e2e/nodes/test_summarizer.py could be removed as pipeline e2e tests cover SearchSummarizationPipeline already

  • Tests in e2e/nodes/test_translator.py can be removed as unit tests exist for translattor and e2e test mostly tests just that the model is good, which is nothing we should test for

  • Tests in e2e/pipelines/test_extractive_qa.py and e2e/pipelines/test_pipeline_topologies.py can become e2e tests

  • Tests in e2e/pipelines/test_standard_pipelines.py and e2e/pipelines/test_standard_pipelines_batch.py can be tested in one go and can then become e2e tests

  • Tests in e2e/pipelines/test_summarization_pipelines.py should move to test_standard_pipelines.py

julian-risch avatar Jul 13 '23 08:07 julian-risch