haystack icon indicating copy to clipboard operation
haystack copied to clipboard

Published 20 hours ago • verified publisher icon deepset-ai

feat: Improve performance and add default media support in FileTypeClassifier

Open vblagoje opened this issue 1 year ago • 2 comments

Related Issues

  • Replaces abandoned PR https://github.com/deepset-ai/haystack/pull/4398
  • Fixes #4393
  • Adds unit tests, the original implementation code and commits remain intact

vblagoje avatar Jun 06 '23 09:06 vblagoje

Pull Request Test Coverage Report for Build 5795297027

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.05%) to 46.938%
Files with Coverage Reduction New Missed Lines %
nodes/file_classifier/file_type.py 2 97.1%
nodes/prompt/invocation_layer/hugging_face.py 9 94.19%
<!-- Total: 11
Totals Coverage Status
Change from base Build 5783638157: 0.05%
Covered Lines: 10915
Relevant Lines: 23254
💛 - Coveralls

coveralls avatar Jun 06 '23 11:06 coveralls

@masci please have another look at this one.

vblagoje avatar Jun 27 '23 15:06 vblagoje

@vblagoje code looks good, can you add the release notes?

masci avatar Aug 07 '23 09:08 masci

@vblagoje code looks good, can you add the release notes?

It should be gtg now @masci LMK

vblagoje avatar Aug 07 '23 16:08 vblagoje