haystack icon indicating copy to clipboard operation
haystack copied to clipboard

Add PyTorch Scatter to relevant Haystack docker files (images)

Open vblagoje opened this issue 2 years ago • 1 comments

Is your feature request related to a problem? Please describe. We omit the installation of https://github.com/rusty1s/pytorch_scatter in Haystack docker images. PyTorch Scatter is needed for Table QA, and its installation should be mandatory in https://github.com/deepset-ai/haystack/blob/main/Dockerfile-GPU There is also a CPU version of this library, and its CPU variant should be installed in CPU Docker image.

Describe the solution you'd like A dockerfile that includes installation of https://github.com/rusty1s/pytorch_scatter . Note that PyTorch Scatter is dependent on the underlying cuda version.

Describe alternatives you've considered No known alternatives

Additional context Add any other context or screenshots about the feature request here.

vblagoje avatar Sep 20 '22 12:09 vblagoje

The new dockerfiles install pytorch-scatter in the base images, as we're going to deprecate the old ones with 1.9 I'd say this is not an issue anymore?

masci avatar Sep 21 '22 15:09 masci

Deal, definitely not, closing.

vblagoje avatar Sep 21 '22 19:09 vblagoje