haystack icon indicating copy to clipboard operation
haystack copied to clipboard

fetch experiment run results from dc

Open FHardow opened this issue 2 years ago • 3 comments

Related Issue(s): ... https://github.com/deepset-ai/haystack/issues/2924

Proposed changes: Adds the functionality in the SDK to fetch the results from an experiment run in DC.

Pre-flight checklist

FHardow avatar Aug 03 '22 14:08 FHardow

@FHardow can we add a test for get_run_results() too please?

Sure. I couldn't find tests for the other functions in that class and skipped them.

FHardow avatar Aug 04 '22 09:08 FHardow

@FHardow can we add a test for get_run_results() too please?

Sure. I couldn't find tests for the other functions in that class and skipped them.

The others are merely proxies to client functions. This one however feeds the EvaluationResult object. I just want to make sure, this works.

tstadel avatar Aug 04 '22 12:08 tstadel

@agnieszka-m thanks for the amazing review!

FHardow avatar Aug 05 '22 12:08 FHardow