haystack-demos icon indicating copy to clipboard operation
haystack-demos copied to clipboard

Api changes from >=1.14 break demo

Open wiesbadener opened this issue 1 year ago • 1 comments

Api changes from >=1.14 are reflected in explore_the_world/ui/utils.py --> query function. With these changes there now is a check for answers "document_ids" that value did not exist <1.14.

However, the haystack-api image: "deepset/haystack:cpu" was not updated in the last six months. Hence, the explore_the_world demo is still using API version 1.12. Resulting in a bug.

Suggesting to change image in docker compose file:

haystack-api:
    image: "deepset/haystack:cpu-main"

Same for explore_the_world/deploy/docker-compose.prod.yml ( currently image: "deepset/haystack:gpu-v1.12.2" )

wiesbadener avatar Jun 28 '23 13:06 wiesbadener

Hi @wiesbadener 👋 thank you for opening the issue, this is a great catch! 🚀 If you're interested in contributing, feel free to open a PR to the repo. If not, no worries, we'll fix this for sure 😊

bilgeyucel avatar Jul 20 '23 09:07 bilgeyucel