Janus icon indicating copy to clipboard operation
Janus copied to clipboard

Update modeling_vlm.py

Open AadiSharma49 opened this issue 10 months ago • 1 comments

hello there i just fix some things like:- Config Class Refactoring: Reduced code duplication using a base configuration class. Naming Conventions: Renamed vision_head to VisionHead for PEP8 compliance while maintaining backward compatibility. Critical Bug Fix: Correctly passed parameters to gen_vision_model during initialization. and other things also hope you you it thanks!!

AadiSharma49 avatar Jan 28 '25 17:01 AadiSharma49

hello there Key Improvements Config Class Refactoring: Reduced code duplication using a base configuration class. Naming Conventions: Renamed vision_head to VisionHead for PEP8 compliance while maintaining backward compatibility. Critical Bug Fix: Correctly passed parameters to gen_vision_model during initialization. Validation Checks: Added an assertion to ensure mask compatibility. Documentation: Enhanced docstrings and comments for clarity. Type Hints: Added detailed type annotations for better code understanding and IDE support.

AadiSharma49 avatar Jan 28 '25 17:01 AadiSharma49