dialog_flow_framework icon indicating copy to clipboard operation
dialog_flow_framework copied to clipboard

Add mypy checks

Open RLKRo opened this issue 2 years ago • 5 comments

As mentioned here viewing codestyle check results is not convenient.

This pull request solves that problem in two ways:

  1. codestyle1.yml -- produces the following output.
  2. codestyle2.yml -- produces the following output.

In my opinion, the second solution is better.

RLKRo avatar Oct 20 '22 09:10 RLKRo

Second option is more obvious for sure. However:

  1. Checkout and triple dependencies installation are required
  2. What's the difference at all if in the end all checks should pass?..

I would suggest either leave the first one or use second with some dependency caching.

pseusys avatar Oct 20 '22 11:10 pseusys

Second option is faster then our current unit-tests (because of that we do not have to wait three linting tests) and it's more atomic style. So I prefer the second one.

kudep avatar Oct 23 '22 10:10 kudep

We will wait until the end of addon's mega-merges.

kudep avatar Oct 24 '22 12:10 kudep

Do we need this PR, i think it can be closed

kudep avatar Jan 27 '23 14:01 kudep

I think it should be used to add mypy check. The name of the branch is codestyle/add-mypy-check. So should probably just rename this PR.

RLKRo avatar Jan 27 '23 14:01 RLKRo