dpdata icon indicating copy to clipboard operation
dpdata copied to clipboard

discriminate frames with virials labels in Multisystem class

Open PKUfjh opened this issue 3 years ago • 2 comments

Sometimes we came across with multisystem (such as quip/gap/xyz format files) which has both frames with virials labels and frames without virials labels. The current implementation of the Multisystems class will lead to error message:

RuntimeError: system has virial, but this does not

But this kind of Multisystems are in fact trainable, so I identify frames with virials in Multisystems, such that Systems will have names as:

C60  C60_virials

The former represents systems with 60 carbon atoms without virials labels, the latter represents systems with 60 carbon atoms with virials labels.

PKUfjh avatar May 24 '22 11:05 PKUfjh

Codecov Report

Merging #294 (31438f0) into devel (c0bb798) will decrease coverage by 0.03%. The diff coverage is 40.00%.

@@            Coverage Diff             @@
##            devel     #294      +/-   ##
==========================================
- Coverage   81.57%   81.53%   -0.04%     
==========================================
  Files          62       62              
  Lines        5244     5249       +5     
==========================================
+ Hits         4278     4280       +2     
- Misses        966      969       +3     
Impacted Files Coverage Δ
dpdata/plugins/ase.py 64.51% <0.00%> (-3.29%) :arrow_down:
dpdata/system.py 85.28% <100.00%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c0bb798...31438f0. Read the comment docs.

codecov-commenter avatar May 24 '22 14:05 codecov-commenter

This is a breaking change to the code that has potential influence on other codes using dpdata.MultiSystems with explicit formula.

I do not support the merging of this PR.

Actually this change just modifies the system names in the MultiSystems frames (add "_virials" to the system names), I do not see what negative influence this change will have on other codes.

PKUfjh avatar May 25 '22 04:05 PKUfjh