DMFF icon indicating copy to clipboard operation
DMFF copied to clipboard

[Feature Request] Support for machine learning force field in OpenMM DMFF plugin

Open tucy22 opened this issue 1 year ago • 1 comments

Summary

Provide support for machine learning (ML) force field in OpenMM DMFF plugin. Present version does not yet support well, such as EANN and SGNN models.

Motivation

The OpenMM DMFF plugin uses save_dmff2tf.py script to transform a JAX model trained in DMFF to a tensorflow model used for OpenMM simulations. In this module, both classical and ADMP force field are considered. While the usage of ML force field in ther transformation is not clear. If ML force field are defined in XML file (referenced as https://github.com/deepmodeling/DMFF/blob/master/docs/user_guide/4.4MLForce.md), there will occur errors in running save_dmff2tf.py script (detailed error message can be browsed in Further Information part). The used ML models are EANN and SGNN.

Suggested Solutions

  1. Revise the potential generation function when using ML, and consider the situation of using ADMP and ML simultaneously.
  2. Provide a specific instruction for the usage of ML forces in OpenMM DMFF Plugin docs.

Further Information, Files, and Links

reportbug.zip test.zip Above files record two different errors when using ML in this plugin.

tucy22 avatar Nov 30 '23 13:11 tucy22

Fixed in PR #154

dingye18 avatar Dec 29 '23 03:12 dingye18