oapi-codegen icon indicating copy to clipboard operation
oapi-codegen copied to clipboard

fix: extensions in properties with allOf section

Open hiddenmarten opened this issue 1 year ago • 3 comments

Hi!

Here's just a simple call that merges allOf section inside of the property if it's needed.

For more context, see the issue.

hiddenmarten avatar Sep 11 '24 21:09 hiddenmarten

It may be necessary to add this functionality to other sections like anyOf. If you'd like to proceed with that, please let me know.

I'd be happy to assist with it.

hiddenmarten avatar Sep 11 '24 21:09 hiddenmarten

Hi @jamietanna !

Should I do something in order to get a review? :)

hiddenmarten avatar Sep 15 '24 23:09 hiddenmarten

Nope, this is in a bit of a backlog, so we'll look to review it once the 2.4.0 release is sorted. Thanks for your patience!

jamietanna avatar Sep 16 '24 06:09 jamietanna

Thanks for the contribution! It looks like this PR was raised from the main branch. As per our contributing guidelines, this can make it difficult for us to push changes to your fork - for instance to directly push a change to address a comment that we would raise, or to finalise changes before merge. Please re-raise the PR from a branch on your repository that isn't main / any protected branches. Thank you in advance 🙇🏼

github-actions[bot] avatar Nov 28 '24 09:11 github-actions[bot]

Closed in favor of https://github.com/oapi-codegen/oapi-codegen/pull/1852

hiddenmarten avatar Dec 01 '24 08:12 hiddenmarten