oapi-codegen Bug: using x-go-type-name results in missing types

This PR describes an issue with type generation when the x-go-type-name is used. The assigned type name is correctly used on the MyTestRequest but types for the enum type and the sub type that also has the x-go-type-name are missing.

Dec 19 '23 15:12 jamesphillpotts-fr

I've managed to make my fix work with a couple of other tweaks to how schema types are used. All tests pass and all generated code tests remain the same except my new one which is fixed by this change.

Dec 20 '23 11:12 jamesphillpotts-fr

Hi @jamietanna @deepmap-marcinr - if you get a minute, is there any chance of triggering the workflow for this PR so that I can make sure it's review-ready? Thanks :-)

Jan 08 '24 11:01 jamesphillpotts-fr

Thanks @jamietanna, it seems to be ok :relieved:

Jan 08 '24 12:01 jamesphillpotts-fr

Thanks for the changes - I'm not going to merge it just yet (and focus on getting the release out now) but will get this in for the next release, hopefully in a couple of weeks. Thanks!

Jan 25 '24 14:01 jamietanna

@jamietanna are we able to get this merged now?

Feb 09 '24 11:02 jamesphillpotts-fr

@jamietanna are we able to get this merged now?

bump :-)

Feb 23 '24 11:02 jamesphillpotts-fr

Hi @jamietanna, just checking in on this PR - if there's anything you need me to do, please let me know.

Mar 18 '24 14:03 jamesphillpotts-fr

Hi @jamietanna is there any chance if getting this PR moving again please?

Apr 18 '24 10:04 jamesphillpotts-fr

Would you mind making sure the latest main branch is merged in? Can't see GitHub Actions having run.

I've got a day off tomorrow which I'm planning on spending a good chunk on oapi-codegen, so hopefully will get to this after #1254

Apr 18 '24 10:04 jamietanna

No problem, I'll get onto that after some lunch :-)

Apr 18 '24 11:04 jamesphillpotts-fr

@jamietanna all up to date, tests pass locally - please trigger the github actions when you get a chance :-)

Apr 18 '24 13:04 jamesphillpotts-fr

Hi @jamietanna how did you get on with looking at this on Friday?

Apr 23 '24 09:04 jamesphillpotts-fr

@jamesphillpotts-fr would you say that this PR should also close off https://github.com/deepmap/oapi-codegen/issues/1354 ?

May 18 '24 14:05 jamietanna

@jamietanna once x-go-type-name is added, I believe so, yes.

May 18 '24 14:05 jamesphillpotts-fr

Thanks for your patience!

May 18 '24 14:05 jamietanna