Eric Bruning
Eric Bruning
@zxdawn a +1 of thanks from me, as I needed this just now. Also, I would say the docstring for `n_min_threshold` is misleading, as it refers to features (tracked regions?)...
Sorry, I meant `min_num`, such as in [`feature_detection_multithreshold_timestep`](https://github.com/climate-processes/tobac/blob/v2.0-dev/tobac/themes/tobac_v1/feature_detection.py#L170)
Ah, maybe a candidate for removal in v. 2.0, then! Or at least deprecation. And thanks for the clarification on `n_min_threshold` - I agree with your interpretation.
Looking at the [default heuristic for `search_range`](https://github.com/climate-processes/tobac/blob/v2.0-dev/tobac/themes/tobac_v1/tracking.py#L156), the units for `v_max` are (grid spacing units)/(time step units)
One more clarification: the `cell` variable in the tracking output is actually an object array like this: `array([nan, 2, 3], dtype=object)` I thought it had a float dtype, but that...
Thanks @freemansw1! If/once #74 goes through, I agree with your suggestion above to make the segmentation ID convention user selectable (with the same kwarg naming convention as for cells).
@mheikenfeld just added my affiliation via PR to your branch.
Pinging this PR now that [siphon/#272](https://github.com/Unidata/siphon/pull/272) has been merged.
Also (@dcamron ?) is there anything special about updating content in the tutorial notebooks? Is it just the main notebook that has to be updated?
Thanks @dcamron, it's ready, after some rethinking of my proposed fix, for your review.