deepkit-framework icon indicating copy to clipboard operation
deepkit-framework copied to clipboard

add type to RouteParameterResolverContext

Open fergusean opened this issue 3 years ago • 2 comments

Summary of changes

Provides resolvers with type information. As an example case, this enables a resolver to determine optionality in order to understand if they should throw vs return undefined in the event they're unable to resolve a value.

Relinquishment of Rights

Please mark following checkbox to confirm that you relinquish all rights of your changes:

  • [X] I waive and relinquish all rights regarding this changes (including code, text, and images) to Deepkit UG (limited), Germany. This changes (including code, text, and images) are under MIT license without name attribution, copyright notice, and permission notice requirement.

fergusean avatar Aug 04 '22 00:08 fergusean

Codecov Report

Merging #341 (642d05f) into master (a6f881d) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #341   +/-   ##
=======================================
  Coverage   78.35%   78.35%           
=======================================
  Files         169      169           
  Lines       17723    17723           
  Branches     4629     4629           
=======================================
  Hits        13887    13887           
  Misses       3836     3836           
Impacted Files Coverage Δ
packages/http/src/router.ts 90.11% <ø> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov-commenter avatar Aug 04 '22 01:08 codecov-commenter

@marcj what's the process for getting this merged?

fergusean avatar Aug 20 '22 03:08 fergusean

@fergusean thanks! merged

marcj avatar Oct 13 '22 03:10 marcj