djl
djl copied to clipboard
Creates a SystemNDManager interface
fixes #1886
This creates an interface for SystemNDManagers. That way, the behavior of skipping over various functions can be moved to the BaseNDManager instead of each individual SystemManager
I'm actually not sure if this is better than override in each SystemNDManager.
In each methods to check instanceof seems odd to me.
It may be a bit odd, but it makes it far easier to implement the NDManager API and to do it correctly. I noticed at least a few engines that were missing some overloads when I was doing this. So, it seems like trying to remember every overload in every engine may be too error prone to rely on
Do we need update lightGBM?