djl icon indicating copy to clipboard operation
djl copied to clipboard

Creates a SystemNDManager interface

Open zachgk opened this issue 3 years ago • 2 comments
trafficstars

fixes #1886

This creates an interface for SystemNDManagers. That way, the behavior of skipping over various functions can be moved to the BaseNDManager instead of each individual SystemManager

zachgk avatar Aug 10 '22 16:08 zachgk

I'm actually not sure if this is better than override in each SystemNDManager.

In each methods to check instanceof seems odd to me.

frankfliu avatar Aug 10 '22 18:08 frankfliu

It may be a bit odd, but it makes it far easier to implement the NDManager API and to do it correctly. I noticed at least a few engines that were missing some overloads when I was doing this. So, it seems like trying to remember every overload in every engine may be too error prone to rely on

zachgk avatar Aug 11 '22 00:08 zachgk

Do we need update lightGBM?

frankfliu avatar Sep 09 '22 22:09 frankfliu