insightface icon indicating copy to clipboard operation
insightface copied to clipboard

Published 20 hours ago • verified publisher icon deepinsight

Bugs in a ArcFace implementation

Open 7rick03ligh7 opened this issue 1 year ago • 0 comments

Can somebody explain me why ArcFace class implementation was changed in this commit https://github.com/deepinsight/insightface/commit/657ae30e41fc53641a50a68694009d0530d9f6b3? In my opinion, here are some bugs:

  1. ArcFace has no_grad() in forward() which can give us wrong gradients
  2. ArcFace object in forward() has no field self.s, instead of it has self.scale

7rick03ligh7 avatar May 22 '23 19:05 7rick03ligh7