web-client-ui icon indicating copy to clipboard operation
web-client-ui copied to clipboard

Dehydrated grid settings should be based on column names instead of indexes

Open vbabich opened this issue 3 years ago • 1 comments

Description

We should use column names instead of indexes in dehydrated grid settings. Otherwise, column shifts can result in grid hydration errors.

Steps to reproduce

  1. Run this command to create a table:
from deephaven import empty_table
t = empty_table(10).update(formulas=["X = `A`"])
  1. Right-click a value in the column X, select Filter By Value -> text is exactly
  2. Open Panels menu, click Export Layout
  3. Update the table, and shift the columns:
from deephaven import empty_table
t = empty_table(10).update(formulas=["I=i", "X = `A`"])
  1. Open Panels menu, click Import Layout

Expected results

Layout restored, table t has the filter applied on string column X

Actual results

Grid hydration fails [will add more details].

vbabich avatar Oct 20 '22 17:10 vbabich

This should most likely include a migration so enterprise workspaces don't break

Similar, but different issue is #643

mattrunyon avatar Nov 30 '22 20:11 mattrunyon