web-client-ui icon indicating copy to clipboard operation
web-client-ui copied to clipboard

`selectedRanges` for TablePlugins do not update when selection is changed

Open mofojed opened this issue 1 year ago • 2 comments

Description

If you create a TablePlugin that listens to selectedRange, it does not update reactively and is just []. Also, panel is no longer passed through. See https://github.com/deephaven/web-client-ui/pull/2181/files which added these props back, but didn't add panel back. By just passing through this.irisGrid.current?.state.selectedRanges, it's not re-rendering the plugin when the selected ranges is actually changed: https://github.com/deephaven/web-client-ui/blob/b5522828a3bc812e7e83440b6d52257a131ce1d2/packages/dashboard-core-plugins/src/panels/IrisGridPanel.tsx#L442

mofojed avatar Oct 29 '24 17:10 mofojed

@mofojed @vbabich It's blocking us from upgrading to DH 0.37? do you have any guidance here, either on timelines or on proposed implementation?

ilyaberdnikov avatar Dec 09 '24 19:12 ilyaberdnikov

@ilyaberdnikov I've opened a PR to fix the issue with panel not being passed through: https://github.com/deephaven/web-client-ui/pull/2308 For selectedRanges not updating, we'll be baking that functionality into ui.table soon: https://github.com/deephaven/deephaven-plugins/issues/822 I'll see if we can also hotfix it for these table plugins to update correctly. I don't believe it was a regression of existing behaviour.

mofojed avatar Dec 09 '24 20:12 mofojed