web-client-ui icon indicating copy to clipboard operation
web-client-ui copied to clipboard

refactor: Remove @adobe/react-spectrum imports where prohibited

Open mattrunyon opened this issue 1 year ago • 1 comments

Fixes #2195

Had to just ignore some of the errors because we compare spectrum components in the styleguide and I didn't want to mess with that for now.

I still think it's a bit confusing that there are things in components/src/spectrum that aren't pure re-exports (e.g. ComboBox). Makes it confusing to know which to use.

mattrunyon avatar Aug 20 '24 19:08 mattrunyon

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.65%. Comparing base (0b37477) to head (7f388aa). Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2198    +/-   ##
========================================
  Coverage   46.64%   46.65%            
========================================
  Files         692      692            
  Lines       38581    38583     +2     
  Branches     9820     9637   -183     
========================================
+ Hits        17998    18000     +2     
- Misses      20530    20572    +42     
+ Partials       53       11    -42     
Flag Coverage Δ
unit 46.65% <ø> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 20 '24 19:08 codecov[bot]