web-client-ui
web-client-ui copied to clipboard
fix: ChartBuilderPlugin fixes for charts built from PPQs in Enterprise
- Don't sanitize the descriptor in
AppDashboards- the descriptor gets sanitized within the objectFetcher itself- By sanitizing too early, we lose metadata needed to load an object
- ChartPanelPlugin uses the
panelFetchto get the underlying object- In cases of a
ParameterizedQueryon Enterprise, we only have the result of theParameterizedQueryrun in theParameterizedQueryPanel- Aside, if we're looking at improving
ParameterizedQuerysupport, we should complete DH-15760 (which would be breaking an internal API)
- Aside, if we're looking at improving
- In cases of a
- Use correct API when fetching a Chart object
Codecov Report
Attention: Patch coverage is 30.00000% with 21 lines in your changes missing coverage. Please review.
Project coverage is 46.78%. Comparing base (
d78ad6d) to head (cb49c8b).
Additional details and impacted files
@@ Coverage Diff @@
## main #2167 +/- ##
==========================================
+ Coverage 46.75% 46.78% +0.02%
==========================================
Files 694 694
Lines 38639 38627 -12
Branches 9785 9659 -126
==========================================
+ Hits 18065 18070 +5
- Misses 20521 20546 +25
+ Partials 53 11 -42
| Flag | Coverage Δ | |
|---|---|---|
| unit | 46.78% <30.00%> (+0.02%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.