web-client-ui icon indicating copy to clipboard operation
web-client-ui copied to clipboard

fix: ChartBuilderPlugin fixes for charts built from PPQs in Enterprise

Open mofojed opened this issue 1 year ago • 1 comments

  • Don't sanitize the descriptor in AppDashboards - the descriptor gets sanitized within the objectFetcher itself
    • By sanitizing too early, we lose metadata needed to load an object
  • ChartPanelPlugin uses the panelFetch to get the underlying object
    • In cases of a ParameterizedQuery on Enterprise, we only have the result of the ParameterizedQuery run in the ParameterizedQueryPanel
      • Aside, if we're looking at improving ParameterizedQuery support, we should complete DH-15760 (which would be breaking an internal API)
  • Use correct API when fetching a Chart object

mofojed avatar Jul 22 '24 19:07 mofojed

Codecov Report

Attention: Patch coverage is 30.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 46.78%. Comparing base (d78ad6d) to head (cb49c8b).

Files with missing lines Patch % Lines
...es/dashboard-core-plugins/src/ChartPanelPlugin.tsx 0.00% 18 Missing :warning:
...ackages/app-utils/src/components/AppDashboards.tsx 0.00% 1 Missing :warning:
.../dashboard-core-plugins/src/ChartBuilderPlugin.tsx 0.00% 1 Missing :warning:
...s/dashboard-core-plugins/src/panels/ChartPanel.tsx 75.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2167      +/-   ##
==========================================
+ Coverage   46.75%   46.78%   +0.02%     
==========================================
  Files         694      694              
  Lines       38639    38627      -12     
  Branches     9785     9659     -126     
==========================================
+ Hits        18065    18070       +5     
- Misses      20521    20546      +25     
+ Partials       53       11      -42     
Flag Coverage Δ
unit 46.78% <30.00%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 22 '24 19:07 codecov[bot]