web-client-ui icon indicating copy to clipboard operation
web-client-ui copied to clipboard

Advanced Filter contains performance and semantics issues

Open devinrsmith opened this issue 1 year ago • 1 comments

Originally filed https://github.com/deephaven/deephaven-core/issues/5700

The "Advanced Filters > contains" filter is creating an "InvokeCondition" with String#matches(String regex), which is much less efficient than "ContainsCondition".

Furthermore, it looks like "Advanced Filters > contains" is creating a case-insensitive by default query; at a minimum, I think it should provide the option for a user to perform a case-sensitive contains, and ideally would perform a case-sensitive contains by default.

devinrsmith avatar Jul 03 '24 23:07 devinrsmith

For GUI filters we always default to case-insensitive. However, adding a "match case" toggle would be reasonable. I've split out the UI change for case-sensitive filtering into a separate ticket - #2136

vbabich avatar Jul 09 '24 15:07 vbabich