web-client-ui icon indicating copy to clipboard operation
web-client-ui copied to clipboard

Theming - remove unused css

Open bmingles opened this issue 2 years ago • 3 comments

As part of theming, we've noticed a few usages of css classes + variables that we'd like to get rid of.

  • Bootstrap $low and $high variables. These are provided by _variables.scss, so we currently just set them to be explicit. See https://getbootstrap.com/docs/5.0/customize/sass/#remove-from-map
    • bootstrap_overrides.scss
      • ~~set $low and $high to ''.~~
      • Remove $mid var and mid from $semantic-colors
    • ~~bootstrap_imports.scss - set $theme-colors: map-remove($theme-colors, 'dark', 'light'); after mixin imports~~
    • Verify there aren't any consumers
    • ThemeExports - remove dark, light, and mid
  • .console-creator .custom-select selector in BaseStyleSheet.scss is defined in DHC. Console creator only exists in DHE. We should confirm whether the css is actually used and either remove it or move it to DHE

Note we'll need to update enterprise as well

bmingles avatar Nov 10 '23 16:11 bmingles

@bmingles should this ticket be closed?

mofojed avatar Mar 12 '24 14:03 mofojed

@mofojed I think this was mostly taken care of. I do still see .console-creator styles in BaseStyleSheet.scss, so technically this may be in the wrong spot. Not sure how much it matters.

bmingles avatar Mar 15 '24 14:03 bmingles

Actually looks like most of the cleanup items still remain

bmingles avatar Mar 15 '24 14:03 bmingles