web-client-ui icon indicating copy to clipboard operation
web-client-ui copied to clipboard

Clean up golden layout base/dark theme scss

Open mofojed opened this issue 2 years ago • 1 comments

There is some scss in the golden layout theme which doesn't make sense as part of the scss override. For example: https://github.com/deephaven/web-client-ui/blob/cf1b368742a7700b08a8d2eda43671856913c9c7/packages/golden-layout/scss/goldenlayout-dark-theme.scss#L73 The "dark" theme scss should only have colour specifications; all layout scss should be in the "base" theme instead. Perhaps this is something that will be irrelevant with the themeing work @bmingles is doing.

mofojed avatar Oct 16 '23 14:10 mofojed

My expectation is that we won't have a dark / light themes specific to golden layout. We'll have base dark / light themes for all of DH that are color variables and golden layout should just pull all color constants from whatever the current underlying theme is.

bmingles avatar Oct 17 '23 13:10 bmingles