deephaven-core icon indicating copy to clipboard operation
deephaven-core copied to clipboard

Upload JVM Error Logs includes extraneous files

Open devinrsmith opened this issue 1 year ago • 1 comments

The "Upload JVM Error Logs" tasks is picking up core.h files. Ideally, this task would be skipped when there are no relevant jvm error logs since we configure if-no-files-found: ignore.

- name: Upload JVM Error Logs
  uses: actions/upload-artifact@v4
  if: failure()
  with:
    name: check-ci-jvm-err
    path: |
      **/*_pid*.log
      **/core.*
    if-no-files-found: ignore

The core.* path is too general.

$ find nightly-check-java11-ci-jvm-err -type f
nightly-check-java11-ci-jvm-err/cpp-client/build/cppClient-docker/deephaven/dhcore/include/public/deephaven/third_party/fmt/core.h
nightly-check-java11-ci-jvm-err/cpp-client/build/cppClientPy-docker/deephaven/dhcore/include/public/deephaven/third_party/fmt/core.h
nightly-check-java11-ci-jvm-err/cpp-client/deephaven/dhcore/include/public/deephaven/third_party/fmt/core.h

devinrsmith avatar Aug 05 '24 17:08 devinrsmith

The change to include core.* was originally made in #2074

devinrsmith avatar Aug 05 '24 17:08 devinrsmith