deepgram-js-sdk icon indicating copy to clipboard operation
deepgram-js-sdk copied to clipboard

[Automation] Shellscript Linting

Open davidvonthenen opened this issue 1 year ago • 2 comments

Proposed changes

Shellscript Linting should adhere to known standards. Look into:

  • github.com/koalaman/shellcheck

This is already implemented in Go and needs to be ported over: https://github.com/deepgram/deepgram-go-sdk/pull/208

Context

Why is this change important to you? How would you use it? How can it benefit other users?

Possible Implementation

Not obligatory, but suggest an idea for implementing addition or change

Other information

Anything else we should know? (e.g. detailed explanation, related issues, links for us to have context, eg. stack overflow, codepen, etc)

davidvonthenen avatar May 10 '24 21:05 davidvonthenen

We don't have any shellscripts :/

lukeocodes avatar Jul 23 '24 12:07 lukeocodes

I will open a PR soon that will introduce some, but if we can add some of these things without shell scripts, we can close.

Reference to this: https://github.com/deepgram/deepgram-js-sdk/issues/284

davidvonthenen avatar Jul 23 '24 16:07 davidvonthenen