duckduckgo-images-api icon indicating copy to clipboard operation
duckduckgo-images-api copied to clipboard

v 0.1.2

Open rachmadaniHaryono opened this issue 4 years ago • 12 comments

this is continuation from https://github.com/rachmadaniHaryono/we-get/issues/18


parts that must be changed/added

  • last line of searching 'audi q6'
  • old print format on printJson function
  • returning search data instead of printing it
  • exit with exit(0). use return instead
  • test suite
  • use python3. python 2.7 is already discontinued this year
  • code example how to use the program on readme
  • handle pr

parts that can be added/changed

  • remove semicolon ending
  • sort import
  • return using yield. this way user can handle how many result are needed.
  • return None when token parsing failed
  • type hinting
  • use urlparser to parse url instead using regex
  • print_json instead printJson
  • use 'user-agents' https://pypi.org/project/user-agents/ for user agent
  • configurable user-agent/sleep time

also maybe contact other recent active fork developer like @mpdev10 and @iainnash

rachmadaniHaryono avatar Apr 12 '20 06:04 rachmadaniHaryono

all the comments look good, let me work on them and send out a PR.

deepanprabhu avatar Apr 12 '20 07:04 deepanprabhu

better contact me at github as i don't check my email as often as github message

rachmadaniHaryono avatar Apr 12 '20 09:04 rachmadaniHaryono

@rachmadaniHaryono - how do we exchange messages ?

deepanprabhu avatar Apr 14 '20 04:04 deepanprabhu

just post on issue page

rachmadaniHaryono avatar Apr 14 '20 20:04 rachmadaniHaryono

Ok, I think we can talk today. Are there any other projects you are working on ? Are you proficient with Java ? I have a project and looking for people to collaborate !

deepanprabhu avatar Apr 15 '20 03:04 deepanprabhu

i'm not proficient with java

Are there any other projects you are working on ?

other than every project on my github page, no.

rachmadaniHaryono avatar Apr 16 '20 00:04 rachmadaniHaryono

@rachmadaniHaryono - I am thinking to build SEO tools, I think python is great for that. Would you be interested in this journey ? I am thinking of huge keyword databases, tools for conducting SEO experiments and eventually a platform for huge crawls, indexing and seo tools.

deepanprabhu avatar Apr 19 '20 21:04 deepanprabhu

I already have a bunch of projects which are hosted with tooling and ready to go. One of them is www.sitemaps.me

deepanprabhu avatar Apr 19 '20 21:04 deepanprabhu

i'm sorry i don't think i want to join that project right now

rachmadaniHaryono avatar Apr 20 '20 02:04 rachmadaniHaryono

Sure, but there are other projects related to gather open data from internet and doing inferences and machine learning on the same. these are related to studying what in a website is causing google positioning and vice versa, to study how traffic flows to a website. @rachmadaniHaryono

deepanprabhu avatar Apr 21 '20 17:04 deepanprabhu

sorry but no

rachmadaniHaryono avatar Apr 22 '20 03:04 rachmadaniHaryono

got it, Thanks !

deepanprabhu avatar Apr 22 '20 04:04 deepanprabhu