Baobab
Baobab copied to clipboard
Update Style
Hi, Please review new look, colors sheme and new background has been added.
Look out for new fonts and: softer borders, textured background lightgrey ( its actually a Baobab trunk ). new fonst colors, font sizes, footer sitting at bottom user dropdown modifications logo img slightly bigger
I still want to get my hands on the Apllication section of the App.
Hi @greeffjean
This is fantastic! Thanks for taking the initiative here! One minor thing I noticed is the footer overlaps the last table slightly:
While you're making style changes, I wonder if you can also help with issue #768? A bunch of stuff is not centred correctly on Firefox (definitely Mac and Linux, not sure about Windows) - for example on Home.js:
and EventHome.js:
One more thing: Can you try a lighter background colour on the status for the event table? (The grey background behind the "Thank you for attending!" and "In Progress" etc) - the reason being that I think the button gets lost (for example in the 2nd screenshot it's hard to tell that "Continue" is a button because the colour is quite similar to the background and is also the same shape as the grey area)
Hi Avishkar.
I'll get back on some more work later this week my PC crashed and sent it to the repair guys yikes!
On Tue, 08 Sep 2020, 13:10 Avishkar Bhoopchand, [email protected] wrote:
@avishkar58 commented on this pull request.
In webapp/src/App.js https://github.com/deep-learning-indaba/Baobab/pull/771#discussion_r484836215 :
@@ -282,7 +282,22 @@ class AppComponent extends Component { user: {}, collapsed: true, eventKey: null,
currentEvent: null
currentEvent: null,styling: {logo: {Is this just temporary while you're experimenting? (styles in the component state rather than the CSS)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/deep-learning-indaba/Baobab/pull/771#pullrequestreview-484029328, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKXI6XETCHVTZW5WI27FGH3SEYGJXANCNFSM4Q6HQHFA .
Resolves #768, Please review here I am not sure I did what exactly what you asked, please review:
- Footer overlap
- Status Buttons
- Text alignment issue on iss768 ( Not too sure what the issue is but added some styling rules that may solve this )