Baobab icon indicating copy to clipboard operation
Baobab copied to clipboard

Application Form still available after close date

Open avishkar58 opened this issue 5 years ago • 7 comments
trafficstars

At the moment, while the Apply menu item is hidden after applications close, users are still able to directly visit the /apply URL and withdraw or update their applications after closing. Instead, the logic should be:

  • If applications are not open yet, it should display a message stating this
  • If applications are closed and they did not start an application before the deadline (ie props.response in ApplicationFormInstance is undefined/null), it should give an error message saying that applications are closed and they did not apply
  • If applications are closed and they did not submit an application before the deadline (ie. isSubmitted=False in ApplicationFormInstance) it should say that they did not submit before the deadline and applications are now closed.
  • If they applied before the deadline (ie props.response is defined, and isSubmitted=True) but applications are now closed:
    • If reviews are still open: they can withdraw but not edit their application
    • If reviews are closed: It should say they applied, but they can't withdraw or edit.

avishkar58 avatar Jun 19 '20 10:06 avishkar58

Hey @greeffjean Some additional information for this one:

  • The event object passed as a prop to ApplicationForm (and ApplicationFormInstance) contains the properties "is_application_open", "is_application_opening", "is_review_open" and "is_review_opening" which you can use to determine whether applications and reviews are closed (note: is_application_open = False and is_application_opening = True means that the applications haven't opened yet, is_application_open = False and is_application_opening = False means they are closed)
  • See the "Submitted" component for the Withdraw and Edit buttons which need to be conditionally visible
  • In order to test this locally with the test event, you can update the dates (application_open, application_close, review_open and review_close) in the event table in the row with id 3

Let me know if you have any other questions

avishkar58 avatar Aug 05 '20 11:08 avishkar58

Hi Avishkar

Great thanks for the new brief, Im down again with docker can you please help me:

*warning [email protected]: Invalid bin field for "file-loader".warning [email protected]: Invalid bin field for "mini-css-extract-plugin".warning [email protected]: Invalid bin field for "terser-webpack-plugin".warning [email protected]: Invalid bin field for "url-loader".error An unexpected error occurred: "https://registry.yarnpkg.com/@svgr/webpack/-/webpack-2.4.1.tgz https://registry.yarnpkg.com/@svgr/webpack/-/webpack-2.4.1.tgz: Request failed "404 Not Found"".info If you think this is a bug, please open a bug report with the information provided in "/yarn-error.log".info Visit https://yarnpkg.com/en/docs/cli/install https://yarnpkg.com/en/docs/cli/install for documentation about this command.ERROR: Service 'webapp' failed to build: The command '/bin/sh -c yarn' returned a non-zero code: 1justines-iMac:Baobab justinecrewebrown$ *

I started working on issue734 as well: The MultiFileUpload Componenet.

Please help me get up and running.

Regards Jean

On Wed, Aug 5, 2020 at 1:55 PM Avishkar Bhoopchand [email protected] wrote:

Hey @greeffjean https://github.com/greeffjean Some additional information for this one:

  • The event object passed as a prop to ApplicationForm (and ApplicationFormInstance) contains the properties "is_application_open", "is_application_opening", "is_review_open" and "is_review_opening" which you can use to determine whether applications and reviews are closed (note: is_application_open = False and is_application_opening = True means that the applications haven't opened yet, is_application_open = False and is_application_opening = False means they are closed)
  • See the "Submitted" component for the Withdraw and Edit buttons which need to be conditionally visible
  • In order to test this locally with the test event, you can update the dates (application_open, application_close, review_open and review_close) in the event table in the row with id 3

Let me know if you have any other questions

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/deep-learning-indaba/Baobab/issues/698#issuecomment-669150327, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKXI6XBJMDR6B2VYMYQOAPDR7FCERANCNFSM4OCS7ZCQ .

greeffjean avatar Aug 06 '20 09:08 greeffjean

Hey Jean,

I haven't seen that type of error before. Is this happening on the develop branch or just on your new branch? Were you running just with docker-compose up (ie using a previously built container) or building a new one? If you haven't built a new container in a while, can you try running docker-compose build again?

Thanks, Avishkar

On Thu, 6 Aug 2020, 10:05 greeffjean, [email protected] wrote:

Hi Avishkar

Great thanks for the new brief, Im down again with docker can you please help me:

*warning [email protected]: Invalid bin field for "file-loader".warning [email protected]: Invalid bin field for "mini-css-extract-plugin".warning [email protected]: Invalid bin field for "terser-webpack-plugin".warning [email protected]: Invalid bin field for "url-loader".error An unexpected error occurred: "https://registry.yarnpkg.com/@svgr/webpack/-/webpack-2.4.1.tgz https://registry.yarnpkg.com/@svgr/webpack/-/webpack-2.4.1.tgz: Request failed "404 Not Found"".info If you think this is a bug, please open a bug report with the information provided in "/yarn-error.log".info Visit https://yarnpkg.com/en/docs/cli/install https://yarnpkg.com/en/docs/cli/install for documentation about this command.ERROR: Service 'webapp' failed to build: The command '/bin/sh -c yarn' returned a non-zero code: 1justines-iMac:Baobab justinecrewebrown$ *

I started working on issue734 as well: The MultiFileUpload Componenet.

Please help me get up and running.

Regards Jean

On Wed, Aug 5, 2020 at 1:55 PM Avishkar Bhoopchand < [email protected]> wrote:

Hey @greeffjean https://github.com/greeffjean Some additional information for this one:

  • The event object passed as a prop to ApplicationForm (and ApplicationFormInstance) contains the properties "is_application_open", "is_application_opening", "is_review_open" and "is_review_opening" which you can use to determine whether applications and reviews are closed (note: is_application_open = False and is_application_opening = True means that the applications haven't opened yet, is_application_open = False and is_application_opening = False means they are closed)
  • See the "Submitted" component for the Withdraw and Edit buttons which need to be conditionally visible
  • In order to test this locally with the test event, you can update the dates (application_open, application_close, review_open and review_close) in the event table in the row with id 3

Let me know if you have any other questions

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/deep-learning-indaba/Baobab/issues/698#issuecomment-669150327 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AKXI6XBJMDR6B2VYMYQOAPDR7FCERANCNFSM4OCS7ZCQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/deep-learning-indaba/Baobab/issues/698#issuecomment-669807744, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFV53F5YJ3XXLOPLG5D4JDR7JW4RANCNFSM4OCS7ZCQ .

avishkar58 avatar Aug 06 '20 09:08 avishkar58

This appears to happening on both dev and my branch, I was running docker-compose up and the terminal just kept on looping code, I then removed all containers and started from scratch, this is the error I keep on getting..

On Thu, Aug 6, 2020 at 11:59 AM Avishkar Bhoopchand < [email protected]> wrote:

Hey Jean,

I haven't seen that type of error before. Is this happening on the develop branch or just on your new branch? Were you running just with docker-compose up (ie using a previously built container) or building a new one? If you haven't built a new container in a while, can you try running docker-compose build again?

Thanks, Avishkar

On Thu, 6 Aug 2020, 10:05 greeffjean, [email protected] wrote:

Hi Avishkar

Great thanks for the new brief, Im down again with docker can you please help me:

*warning [email protected]: Invalid bin field for "file-loader".warning [email protected]: Invalid bin field for "mini-css-extract-plugin".warning [email protected]: Invalid bin field for "terser-webpack-plugin".warning [email protected]: Invalid bin field for "url-loader".error An unexpected error occurred: "https://registry.yarnpkg.com/@svgr/webpack/-/webpack-2.4.1.tgz https://registry.yarnpkg.com/@svgr/webpack/-/webpack-2.4.1.tgz: Request failed "404 Not Found"".info If you think this is a bug, please open a bug report with the information provided in "/yarn-error.log".info Visit https://yarnpkg.com/en/docs/cli/install https://yarnpkg.com/en/docs/cli/install for documentation about this command.ERROR: Service 'webapp' failed to build: The command '/bin/sh -c yarn' returned a non-zero code: 1justines-iMac:Baobab justinecrewebrown$

I started working on issue734 as well: The MultiFileUpload Componenet.

Please help me get up and running.

Regards Jean

On Wed, Aug 5, 2020 at 1:55 PM Avishkar Bhoopchand < [email protected]> wrote:

Hey @greeffjean https://github.com/greeffjean Some additional information for this one:

  • The event object passed as a prop to ApplicationForm (and ApplicationFormInstance) contains the properties "is_application_open", "is_application_opening", "is_review_open" and "is_review_opening" which you can use to determine whether applications and reviews are closed (note: is_application_open = False and is_application_opening = True means that the applications haven't opened yet, is_application_open = False and is_application_opening = False means they are closed)
  • See the "Submitted" component for the Withdraw and Edit buttons which need to be conditionally visible
  • In order to test this locally with the test event, you can update the dates (application_open, application_close, review_open and review_close) in the event table in the row with id 3

Let me know if you have any other questions

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <

https://github.com/deep-learning-indaba/Baobab/issues/698#issuecomment-669150327

, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AKXI6XBJMDR6B2VYMYQOAPDR7FCERANCNFSM4OCS7ZCQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/deep-learning-indaba/Baobab/issues/698#issuecomment-669807744 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABFV53F5YJ3XXLOPLG5D4JDR7JW4RANCNFSM4OCS7ZCQ

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/deep-learning-indaba/Baobab/issues/698#issuecomment-669834887, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKXI6XHTSHSOVVBFUVNNMOLR7J5HRANCNFSM4OCS7ZCQ .

greeffjean avatar Aug 06 '20 10:08 greeffjean

So to sum up this error is showing on docker-compose build Any ideas?

On Thu, Aug 6, 2020 at 12:04 PM jean greeff [email protected] wrote:

This appears to happening on both dev and my branch, I was running docker-compose up and the terminal just kept on looping code, I then removed all containers and started from scratch, this is the error I keep on getting..

On Thu, Aug 6, 2020 at 11:59 AM Avishkar Bhoopchand < [email protected]> wrote:

Hey Jean,

I haven't seen that type of error before. Is this happening on the develop branch or just on your new branch? Were you running just with docker-compose up (ie using a previously built container) or building a new one? If you haven't built a new container in a while, can you try running docker-compose build again?

Thanks, Avishkar

On Thu, 6 Aug 2020, 10:05 greeffjean, [email protected] wrote:

Hi Avishkar

Great thanks for the new brief, Im down again with docker can you please help me:

*warning [email protected]: Invalid bin field for "file-loader".warning [email protected]: Invalid bin field for "mini-css-extract-plugin".warning [email protected]: Invalid bin field for "terser-webpack-plugin".warning [email protected]: Invalid bin field for "url-loader".error An unexpected error occurred: "https://registry.yarnpkg.com/@svgr/webpack/-/webpack-2.4.1.tgz https://registry.yarnpkg.com/@svgr/webpack/-/webpack-2.4.1.tgz: Request failed "404 Not Found"".info If you think this is a bug, please open a bug report with the information provided in "/yarn-error.log".info Visit https://yarnpkg.com/en/docs/cli/install https://yarnpkg.com/en/docs/cli/install for documentation about this command.ERROR: Service 'webapp' failed to build: The command '/bin/sh -c yarn' returned a non-zero code: 1justines-iMac:Baobab justinecrewebrown$ *

I started working on issue734 as well: The MultiFileUpload Componenet.

Please help me get up and running.

Regards Jean

On Wed, Aug 5, 2020 at 1:55 PM Avishkar Bhoopchand < [email protected]> wrote:

Hey @greeffjean https://github.com/greeffjean Some additional information for this one:

  • The event object passed as a prop to ApplicationForm (and ApplicationFormInstance) contains the properties "is_application_open", "is_application_opening", "is_review_open" and "is_review_opening" which you can use to determine whether applications and reviews are closed (note: is_application_open = False and is_application_opening = True means that the applications haven't opened yet, is_application_open = False and is_application_opening = False means they are closed)
  • See the "Submitted" component for the Withdraw and Edit buttons which need to be conditionally visible
  • In order to test this locally with the test event, you can update the dates (application_open, application_close, review_open and review_close) in the event table in the row with id 3

Let me know if you have any other questions

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <

https://github.com/deep-learning-indaba/Baobab/issues/698#issuecomment-669150327

, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AKXI6XBJMDR6B2VYMYQOAPDR7FCERANCNFSM4OCS7ZCQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/deep-learning-indaba/Baobab/issues/698#issuecomment-669807744 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABFV53F5YJ3XXLOPLG5D4JDR7JW4RANCNFSM4OCS7ZCQ

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/deep-learning-indaba/Baobab/issues/698#issuecomment-669834887, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKXI6XHTSHSOVVBFUVNNMOLR7J5HRANCNFSM4OCS7ZCQ .

greeffjean avatar Aug 06 '20 10:08 greeffjean

Hey Kale-ab,

Any ideas what might be causing this?

On Thu, 6 Aug 2020 at 11:05, greeffjean [email protected] wrote:

So to sum up this error is showing on docker-compose build Any ideas?

On Thu, Aug 6, 2020 at 12:04 PM jean greeff [email protected] wrote:

This appears to happening on both dev and my branch, I was running docker-compose up and the terminal just kept on looping code, I then removed all containers and started from scratch, this is the error I keep on getting..

On Thu, Aug 6, 2020 at 11:59 AM Avishkar Bhoopchand < [email protected]> wrote:

Hey Jean,

I haven't seen that type of error before. Is this happening on the develop branch or just on your new branch? Were you running just with docker-compose up (ie using a previously built container) or building a new one? If you haven't built a new container in a while, can you try running docker-compose build again?

Thanks, Avishkar

On Thu, 6 Aug 2020, 10:05 greeffjean, [email protected] wrote:

Hi Avishkar

Great thanks for the new brief, Im down again with docker can you please help me:

*warning [email protected]: Invalid bin field for "file-loader".warning [email protected]: Invalid bin field for "mini-css-extract-plugin".warning [email protected]: Invalid bin field for "terser-webpack-plugin".warning [email protected]: Invalid bin field for "url-loader".error An unexpected error occurred: "https://registry.yarnpkg.com/@svgr/webpack/-/webpack-2.4.1.tgz https://registry.yarnpkg.com/@svgr/webpack/-/webpack-2.4.1.tgz: Request failed "404 Not Found"".info If you think this is a bug, please open a bug report with the information provided in "/yarn-error.log".info Visit https://yarnpkg.com/en/docs/cli/install https://yarnpkg.com/en/docs/cli/install for documentation about this command.ERROR: Service 'webapp' failed to build: The command '/bin/sh -c yarn' returned a non-zero code: 1justines-iMac:Baobab justinecrewebrown$ *

I started working on issue734 as well: The MultiFileUpload Componenet.

Please help me get up and running.

Regards Jean

On Wed, Aug 5, 2020 at 1:55 PM Avishkar Bhoopchand < [email protected]> wrote:

Hey @greeffjean https://github.com/greeffjean Some additional information for this one:

  • The event object passed as a prop to ApplicationForm (and ApplicationFormInstance) contains the properties "is_application_open", "is_application_opening", "is_review_open" and "is_review_opening" which you can use to determine whether applications and reviews are closed (note: is_application_open = False and is_application_opening = True means that the applications haven't opened yet, is_application_open = False and is_application_opening = False means they are closed)
  • See the "Submitted" component for the Withdraw and Edit buttons which need to be conditionally visible
  • In order to test this locally with the test event, you can update the dates (application_open, application_close, review_open and review_close) in the event table in the row with id 3

Let me know if you have any other questions

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <

https://github.com/deep-learning-indaba/Baobab/issues/698#issuecomment-669150327

, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AKXI6XBJMDR6B2VYMYQOAPDR7FCERANCNFSM4OCS7ZCQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <

https://github.com/deep-learning-indaba/Baobab/issues/698#issuecomment-669807744

, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ABFV53F5YJ3XXLOPLG5D4JDR7JW4RANCNFSM4OCS7ZCQ

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/deep-learning-indaba/Baobab/issues/698#issuecomment-669834887 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AKXI6XHTSHSOVVBFUVNNMOLR7J5HRANCNFSM4OCS7ZCQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/deep-learning-indaba/Baobab/issues/698#issuecomment-669837480, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFV53D5RQNWANMLSXUX6VTR7J55LANCNFSM4OCS7ZCQ .

avishkar58 avatar Aug 06 '20 10:08 avishkar58

Just watch this space I think I may have fixed the issue

On Thu, Aug 6, 2020 at 12:20 PM Avishkar Bhoopchand < [email protected]> wrote:

Hey Kale-ab,

Any ideas what might be causing this?

On Thu, 6 Aug 2020 at 11:05, greeffjean [email protected] wrote:

So to sum up this error is showing on docker-compose build Any ideas?

On Thu, Aug 6, 2020 at 12:04 PM jean greeff [email protected] wrote:

This appears to happening on both dev and my branch, I was running docker-compose up and the terminal just kept on looping code, I then removed all containers and started from scratch, this is the error I keep on getting..

On Thu, Aug 6, 2020 at 11:59 AM Avishkar Bhoopchand < [email protected]> wrote:

Hey Jean,

I haven't seen that type of error before. Is this happening on the develop branch or just on your new branch? Were you running just with docker-compose up (ie using a previously built container) or building a new one? If you haven't built a new container in a while, can you try running docker-compose build again?

Thanks, Avishkar

On Thu, 6 Aug 2020, 10:05 greeffjean, [email protected] wrote:

Hi Avishkar

Great thanks for the new brief, Im down again with docker can you please help me:

*warning [email protected]: Invalid bin field for "file-loader".warning [email protected]: Invalid bin field for "mini-css-extract-plugin".warning [email protected]: Invalid bin field for "terser-webpack-plugin".warning [email protected]: Invalid bin field for "url-loader".error An unexpected error occurred: "https://registry.yarnpkg.com/@svgr/webpack/-/webpack-2.4.1.tgz https://registry.yarnpkg.com/@svgr/webpack/-/webpack-2.4.1.tgz: Request failed "404 Not Found"".info If you think this is a bug, please open a bug report with the information provided in "/yarn-error.log".info Visit https://yarnpkg.com/en/docs/cli/install https://yarnpkg.com/en/docs/cli/install for documentation about this command.ERROR: Service 'webapp' failed to build: The command '/bin/sh -c yarn' returned a non-zero code: 1justines-iMac:Baobab justinecrewebrown$ *

I started working on issue734 as well: The MultiFileUpload Componenet.

Please help me get up and running.

Regards Jean

On Wed, Aug 5, 2020 at 1:55 PM Avishkar Bhoopchand < [email protected]> wrote:

Hey @greeffjean https://github.com/greeffjean Some additional information for this one:

  • The event object passed as a prop to ApplicationForm (and ApplicationFormInstance) contains the properties "is_application_open", "is_application_opening", "is_review_open" and "is_review_opening" which you can use to determine whether applications and reviews are closed (note: is_application_open = False and is_application_opening = True means that the applications haven't opened yet, is_application_open = False and is_application_opening = False means they are closed)
  • See the "Submitted" component for the Withdraw and Edit buttons which need to be conditionally visible
  • In order to test this locally with the test event, you can update the dates (application_open, application_close, review_open and review_close) in the event table in the row with id 3

Let me know if you have any other questions

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <

https://github.com/deep-learning-indaba/Baobab/issues/698#issuecomment-669150327

, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AKXI6XBJMDR6B2VYMYQOAPDR7FCERANCNFSM4OCS7ZCQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <

https://github.com/deep-learning-indaba/Baobab/issues/698#issuecomment-669807744

, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ABFV53F5YJ3XXLOPLG5D4JDR7JW4RANCNFSM4OCS7ZCQ

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <

https://github.com/deep-learning-indaba/Baobab/issues/698#issuecomment-669834887

,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AKXI6XHTSHSOVVBFUVNNMOLR7J5HRANCNFSM4OCS7ZCQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/deep-learning-indaba/Baobab/issues/698#issuecomment-669837480 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABFV53D5RQNWANMLSXUX6VTR7J55LANCNFSM4OCS7ZCQ

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/deep-learning-indaba/Baobab/issues/698#issuecomment-669844053, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKXI6XD3U7G4WG3HSBGFXJLR7J7V7ANCNFSM4OCS7ZCQ .

greeffjean avatar Aug 06 '20 12:08 greeffjean