MusicPiped icon indicating copy to clipboard operation
MusicPiped copied to clipboard

Cannot dismiss notification after exiting app

Open letkan opened this issue 5 years ago • 11 comments

Thanks for this app looks promising. One thing I can't do is to get rid of the notification once I quit the app without disabling it. Most apps have a way to dismiss the notification but this one can be hidden only by disabling "My background service" (minimize). I'd expect that once I quit the app the notification should go also or some way to dismiss it without disabling it (New Pipe has a checkbox for example).

letkan avatar Mar 26 '19 08:03 letkan

Isn't there a close button in notification? It should close app, and dismiss notification too

deep-gaurav avatar Mar 26 '19 14:03 deep-gaurav

Unfortunately there isn't. I'm on ArrowOS (Android 9) with Lean Launcher and usually with all apps that have notifications when I drop down the notifications at the bottom of it there is a "Clear All" button (which BTW it clears all except MP) but with MusicPiped it's missing. If I swipe right/left my only option is to disable "My background service". Tested on 2 devices, same OS one is treble one is not. Also music can play even after I quit the app.

letkan avatar Mar 26 '19 17:03 letkan

Screenshot_20190326-195441

Aren't notification like this? The 4th button i.e button after next is close button

deep-gaurav avatar Mar 26 '19 18:03 deep-gaurav

Shit! I'm on a black theme and the controls don't show, you're right :). I don't know if you can adapt the controls (white) if the system theme is dark or black. This is a system-wide black theme which is probably available on most custom roms. Or maybe you can force the notification to stay white.

letkan avatar Mar 26 '19 18:03 letkan

App initially used system icons which would have adapted according to system theme probably but some device does not provide all icons and they would not appear in them (check issue #17 ) I'd to use my custom icon. It looks like both implementation has their own cons,. I probably can add a white border to icon so they'll be visible in dark background

deep-gaurav avatar Mar 26 '19 19:03 deep-gaurav

I probably can add a white border to icon so they'll be visible in dark background

That sounds like the right approach. Thanks for the time.

letkan avatar Mar 26 '19 19:03 letkan

I managed to build the app myself and took the opportunity to change the color of the controls to blue (#1f5cf3) in the drawable/*.xml and they look pretty good with both black and white themes. Now that I felt I can control the app I looked at the other features, impressed.

letkan avatar Mar 27 '19 19:03 letkan

Sorry for all delay,. got really busy, pushed release, closing issue

deep-gaurav avatar Apr 07 '19 14:04 deep-gaurav

I'm experiencing the same issue on a Samsung device running Android Nougat with MusicPiped v2.1.2. No custom theming beyond what Samsung includes by default: the notification area is white.

There is no close button in the MusicPiped notification. This is true both when there is a song playing, and when there is not (in which case there is an empty MusicPiped notification).

Even with nothing playing, closing MusicPiped results in it immediately restarting, which either causes a MusicPiped crash, or recreates the notification.

I've tried clearing data and cache, as well as uninstalling and reinstalling MusicPiped.

Regardless, really appreciate the app!

Gitoffthelawn avatar Sep 27 '19 00:09 Gitoffthelawn

I'll reopen issue, for now. Thanks for reporting

deep-gaurav avatar Sep 27 '19 00:09 deep-gaurav

I can confirm the same Problem. Even in normal Mode (No dark mode)

littlefico avatar Oct 15 '19 14:10 littlefico