IF icon indicating copy to clipboard operation
IF copied to clipboard

Need much clearer instructions about what needs to be done for torch>=2.0.0

Open phalexo opened this issue 1 year ago • 4 comments

This is not clear. " If you are using torch>=2.0.0, make sure to delete all enable_xformers_memory_efficient_attention() functions. "

phalexo avatar Apr 29 '23 13:04 phalexo

I can see only a single call to this function. Should that call be commented out?

phalexo avatar Apr 29 '23 13:04 phalexo

There are 3, one per stage. There is an embedded comment that says to remove this line

minskicat avatar Apr 29 '23 14:04 minskicat

There are 3, one per stage. There is an embedded comment that says to remove this line

Hm. I grepped for it, saw only one. Do you know which files?

phalexo avatar Apr 29 '23 14:04 phalexo

There are 3, one per stage. There is an embedded comment that says to remove this line

Hm. I grepped for it, saw only one. Do you know which files?

You dont need to change anything in the repo. You just need to change it in the code you actually use to run it, like the examples in the readme or the notebooks

kanttouchthis avatar Apr 29 '23 16:04 kanttouchthis

It would just be nice to update to pytorch 2.0 generally, as the base pytorch instructions don't even have 1.13 (I'm sure we can easily find it), and if we don't install manually and just pip install deepfloyd 1.2-rc0, we get a CPU version of torch 1.13, so then that needs to be updated to GPU, but then because it's pip, you can start accidentally screwing up requirements for torchvision and other modules.

SpaceCowboy850 avatar May 03 '23 22:05 SpaceCowboy850