David Buchan-Swanson
David Buchan-Swanson
Hmm. Interesting. From [here](http://icu-project.org/apiref/icu4c/ucal_8h.html#ac5243211dec55651f308c34a011eb337) it looks like we could just `ucal_setDefaultTimeZone`, right? Or, something like [this from FreeRDP](https://github.com/FreeRDP/FreeRDP/commit/3d487d0718b5fbba3dd80dedd515dde2e5ae11ba) might be helpful
I haven't actually looked at this repo yet (i thought it was a private project tbh). That's cool. yeah, a fast test cycle that doesn't include ngrok and resending github...
if this project is OSS tho, does that mean I could host my own danger runner, for instance?
Did a bit of digging - `KeystoreAESCBC` seems to be very slow when running `CipherStorageBase#extractKey`, specifically when doing `keyStore.getKey(safeAlias, null)`. I'm not too sure why there is a slowdown between...
from 4.0.5: ```java // CipherStorageKeystoreAESCBC.java line 101 key = keyStore.getKey(service, null); // 5ms average over 5 runs ``` from 6.0.0 ```java // CipherStorageBase.java line 234 key = keyStore.getKey(safeAlias, null); //...
@OleksandrKucherenko I tried doing that, too, and it was not noticeably quicker. There is a good chance that I got it mixed up with other tests I was trying, tho.
Front end? Back end? Bots as in github bots? Testing frameworks as in online test runners (CI Platform), or package used to write tests with?
Hey @cortinico - I tested this using the debugger to ensure that the `isRunningOnStockEmulator` method returns `true` for the `Build.FINGERPRINT` of the simulator I was running. It didn't before the...
☝️ yeah i have both installed, and did the fix, and never noticed a problem
i wonder if something like [Danger](https://danger.systems/) could be used? Although not sure you'd want the configuration for that to live inside of this codebase.