scramble icon indicating copy to clipboard operation
scramble copied to clipboard
verified publisher icon dedoc

No hints are displayed when merging requests

Open DarKsandr opened this issue 1 year ago • 7 comments

I have two requests that I merged into one. When applying the received request, there are no hints. Снимок экрана от 2024-07-26 11-33-47 Снимок экрана от 2024-07-26 11-34-42 Снимок экрана от 2024-07-26 11-39-15 Снимок экрана от 2024-07-26 11-39-49 Снимок экрана от 2024-07-26 11-40-05

DarKsandr avatar Jul 26 '24 08:07 DarKsandr

I thought that double-specifying the request would work, but only the first one that exists is displayed. Снимок экрана от 2024-07-26 21-03-11 Снимок экрана от 2024-07-26 21-04-33

DarKsandr avatar Jul 26 '24 18:07 DarKsandr

@romalytvynenko is there a solution to the problem?

DarKsandr avatar Jul 31 '24 10:07 DarKsandr

@DarKsandr it should be fixed with https://github.com/dedoc/scramble/pull/237 , but this is not that fast.

romalytvynenko avatar Jul 31 '24 12:07 romalytvynenko

@romalytvynenko got it, thanks. but isn't the second example a bug? shouldn't it combine several requests? i thought it would work the same way as in this example: Снимок экрана от 2024-07-31 15-51-08 Снимок экрана от 2024-07-31 15-49-25

DarKsandr avatar Jul 31 '24 12:07 DarKsandr

Personally to me this is hard to consider it as a bug, as I never saw such usage of requests. I agree this may be improved, but rather than an improvement, not a bug, IMO

romalytvynenko avatar Jul 31 '24 14:07 romalytvynenko

@romalytvynenko If such an improvement were to appear, I would be glad. But IMHO it is still a bug, because the parser does not take into account all method requests, but only the first one.

DarKsandr avatar Jul 31 '24 14:07 DarKsandr

@DarKsandr feel free to open a PR :-)

romalytvynenko avatar Jul 31 '24 17:07 romalytvynenko

@DarKsandr The fix is released in v0.12.25: https://github.com/dedoc/scramble/releases/tag/v0.12.25

romalytvynenko avatar Jul 26 '25 19:07 romalytvynenko