kyber icon indicating copy to clipboard operation
kyber copied to clipboard
verified publisher icon dedis

Int32 repro & ConstantTime

Open ValeriodeSa opened this issue 5 months ago • 15 comments

Depends on #582

[!NOTE] Add a constant-time build mode with a new big-int backend, refactor code/tests behind build tags, switch DKG/VSS/DSS to uint32 indices, and update CI, lint, and coverage to support both modes.

  • Core/Crypto:
    • Introduce constant-time build mode (constantTime) with a new compatible big-integer backend (compatible/bigmod) and assembly accelerators; gate existing variable‑time code/tests behind !constantTime.
    • Refactor suites: constant-time exports limited, variable‑time suites moved to *_vartime.go.
  • Protocols/Types:
    • Standardize indices/thresholds to uint32 across DKG/VSS/DSS and related APIs; fix range and index handling.
    • Minor API cleanups (e.g., direct []kyber.Point use in anon, mask ops, recovery functions).
  • Tests/Benchmarks:
    • Add/adjust tests and benchmarks for both modes (incl. BLS12‑381 fixtures); split vartime tests with build tags.
  • CI/Tooling:
    • Expand test matrix to run with/without constantTime; aggregate coverage from both; revamp lint config; minor Makefile/log tweaks; ignore *.bck.yml.

Written by Cursor Bugbot for commit 01aac072c3d21a5a5e431d556da16934ef5d69ae. This will update automatically on new commits. Configure here.

ValeriodeSa avatar Jul 24 '25 17:07 ValeriodeSa

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

github-actions[bot] avatar Jul 24 '25 17:07 github-actions[bot]

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

github-actions[bot] avatar Aug 05 '25 11:08 github-actions[bot]

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

github-actions[bot] avatar Aug 11 '25 13:08 github-actions[bot]

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

github-actions[bot] avatar Aug 11 '25 14:08 github-actions[bot]

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

github-actions[bot] avatar Aug 15 '25 08:08 github-actions[bot]

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

github-actions[bot] avatar Aug 18 '25 07:08 github-actions[bot]

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

github-actions[bot] avatar Aug 18 '25 08:08 github-actions[bot]

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

github-actions[bot] avatar Aug 18 '25 13:08 github-actions[bot]

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

github-actions[bot] avatar Aug 19 '25 09:08 github-actions[bot]

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

github-actions[bot] avatar Aug 20 '25 16:08 github-actions[bot]

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

github-actions[bot] avatar Aug 20 '25 16:08 github-actions[bot]

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

github-actions[bot] avatar Aug 26 '25 13:08 github-actions[bot]

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

github-actions[bot] avatar Sep 08 '25 11:09 github-actions[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 17 '25 11:11 CLAassistant

Quality Gate Failed Quality Gate failed

Failed conditions
37.2% Duplication on New Code (required ≤ 10%)
D Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

sonarqubecloud[bot] avatar Nov 24 '25 15:11 sonarqubecloud[bot]