kyber icon indicating copy to clipboard operation
kyber copied to clipboard

Bls12381

Open matteosz opened this issue 11 months ago • 4 comments

This PR introduces a different implementation of bls12381 (kilic) to kyber, which is faster than the actual circl implementation

matteosz avatar Mar 25 '24 09:03 matteosz

Quality Gate Failed Quality Gate failed

Failed conditions
32.6% Duplication on New Code (required ≤ 10%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Mar 25 '24 09:03 sonarqubecloud[bot]

I know this is a work in progress, but in general adding (a lot) more documentation would be helpful, as right now the code seems mostly undocumented.

It would also seem that go fmt wasn't run on all files. You might want to configure your editor to do this automatically.

pierluca avatar Mar 29 '24 13:03 pierluca

I know this is a work in progress, but in general adding (a lot) more documentation would be helpful, as right now the code seems mostly undocumented.

It would also seem that go fmt wasn't run on all files. You might want to configure your editor to do this automatically.

Yep, I'll add some more doc. This was put on hold as I'm waiting the drand fork to be merged before working and merging this PR, to avoid further conflicts

matteosz avatar Apr 04 '24 20:04 matteosz

Please retry analysis of this Pull-Request directly on SonarCloud

sonarqubecloud[bot] avatar Jun 07 '24 16:06 sonarqubecloud[bot]