kyber icon indicating copy to clipboard operation
kyber copied to clipboard

Misleading comment on the "hashToPoint()" function

Open kubasiemion opened this issue 4 years ago • 1 comments

File kyber/pairing/bn256/point.go /, lines 224-225 A simple quid-pro-quo, but we should have mercy on the people trying to follow the algorithms: // hashes a byte slice into two points on a curve represented by big.Int // ideally we want to do this using gfP, but gfP doesn't have a ModSqrt function func hashToPoint(m []byte) (*big.Int, *big.Int) {...}

Should be: "hashes into a point represented by two big.Int's"

kubasiemion avatar Feb 22 '21 10:02 kubasiemion

Thanks for the comment. Github makes it now really easy to propose changes to the files. So please feel free to open a PR against bn256/point.go.

ineiti avatar Feb 23 '21 09:02 ineiti