kyber
kyber copied to clipboard
The tests are missing negative tests and test-vectors
Security Code Review observation:
For example, it seems the shuffle tests are not testing the verification of a wrong shuffle nor providing test-vectors.
At least the following packages are missing negatives:
- [x] shuffle
- [ ] proof/deniable
- [ ] proof/proof
- [ ] proof/dleq/dleq
- [ ] sign/anon (has no test)
- [ ] sign/bdn
- [ ] sign/cosi
- [ ] sign/schnorr
- [ ] sign/tbls