dela
dela copied to clipboard
Minows uses a DB to handle keys
Pull Request Test Coverage Report for Build 15610563053
Details
- 60 of 76 (78.95%) changed or added relevant lines in 6 files are covered.
- 6 unchanged lines in 2 files lost coverage.
- Overall coverage decreased (-0.04%) to 94.448%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| mino/minows/mod.go | 26 | 30 | 86.67% |
| dkg/pedersen/dkg.go | 22 | 27 | 81.48% |
| mino/minows/controller.go | 5 | 12 | 41.67% |
| <!-- | Total: | 60 | 76 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| dkg/pedersen/dkg.go | 1 | 97.01% |
| mino/minows/session.go | 5 | 76.25% |
| <!-- | Total: | 6 |
| Totals | |
|---|---|
| Change from base Build 14840032249: | -0.04% |
| Covered Lines: | 16894 |
| Relevant Lines: | 17887 |
💛 - Coveralls
Why? What is the reason for this PR? Is there an issue attached to it?
From what I see, the private key index is only used in the tests. I propose to change the tests to use one db per instance, so you don't need to have a key-index. Because you'll also have other data in the db, so you'll need multiple dbs anyway.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
76.5% Coverage on New Code
0.0% Duplication on New Code