dela icon indicating copy to clipboard operation
dela copied to clipboard

Minows uses a DB to handle keys

Open jbsv opened this issue 7 months ago • 3 comments

jbsv avatar Jun 03 '25 05:06 jbsv

Pull Request Test Coverage Report for Build 15610563053

Details

  • 60 of 76 (78.95%) changed or added relevant lines in 6 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 94.448%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mino/minows/mod.go 26 30 86.67%
dkg/pedersen/dkg.go 22 27 81.48%
mino/minows/controller.go 5 12 41.67%
<!-- Total: 60 76
Files with Coverage Reduction New Missed Lines %
dkg/pedersen/dkg.go 1 97.01%
mino/minows/session.go 5 76.25%
<!-- Total: 6
Totals Coverage Status
Change from base Build 14840032249: -0.04%
Covered Lines: 16894
Relevant Lines: 17887

💛 - Coveralls

coveralls avatar Jun 04 '25 15:06 coveralls

Why? What is the reason for this PR? Is there an issue attached to it?

From what I see, the private key index is only used in the tests. I propose to change the tests to use one db per instance, so you don't need to have a key-index. Because you'll also have other data in the db, so you'll need multiple dbs anyway.

ineiti avatar Jun 05 '25 06:06 ineiti