cothority icon indicating copy to clipboard operation
cothority copied to clipboard

Darc ECDSA

Open pm-duokey opened this issue 3 years ago • 3 comments

What this PR does

See commit message This PR


🙅‍ Friendly checklist:

  • [ ] 0. Code comments are added (or updated) when/where needed and explain the WHY of the code.
  • [ ] 1. Design choices, user documentation and any additional doc are added (or updated) in READMEs.
  • [ ] 2. Any new behaviour is tested and small units of code that can be are unit tested.
  • [ ] 3. Code comments are added on tests to explain what they do.
  • [ ] 4. Errors are systematically wrapped with a meaningful message using xerrors.Errorf and the %v verb.
  • [ ] 5. Hard limit of 80 chars is always respected.
  • [ ] 6. Changes are backward compatible.
  • [ ] 7. Indentation level does not exceed 5, although 4 is already suspicious.
  • [ ] 8. Functions, files, and packages are kept to a manageable size and decomposed into smaller units if needed.
  • [ ] 9. There are no magic values.

pm-duokey avatar Dec 21 '21 12:12 pm-duokey

You can also use the Commit Suggestions in the comments to directly add the suggestions I made.

ineiti avatar Dec 22 '21 10:12 ineiti

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
8.4% 8.4% Duplication

sonarqubecloud[bot] avatar Dec 29 '21 11:12 sonarqubecloud[bot]

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
3.9% 3.9% Duplication

sonarqubecloud[bot] avatar Mar 04 '22 09:03 sonarqubecloud[bot]