ded
Adds conditional to hanlde if redis becomes unavailable
Nice package!!
However using this in production (even with a highly available Redis cluster), means that the developer needs to handle if Redis becomes unavailable.
This is highly unlikely, but we would not want our rate limiter to kill our route if Redis has any issue(s).
It's pretty hard to swap out middleware in a running express app when it is setup like this:
app.post('/api/endpoint', limiter(limitOptions),
function (req, res) { ... }
);
I this was the simplest workaround I could think of. I will write some tests if you would like but, this patch is pretty easy to manually test...
Hi @michaelerobertsjr thanks for your contribution!
This is a good and viable patch. Would you mind sticking to the existing style of the code. run make lint and be sure to remove the double quotes and add a whitespace after keywords like function and if. Also, please remove the version bump. I'll take care of that myself.
When finished push it back and I'll merge it.
Any update on merging this change in? Its definitely a feature that I need. Thanks.
@ded Can you have a look now? Removed the double quotes, added white space, and removed the version bump. Thx.
