bonzo icon indicating copy to clipboard operation
bonzo copied to clipboard
verified publisher icon ded

Fixed offset function for objects in iframes.

Open velocityzen opened this issue 12 years ago • 5 comments

So. It passed tests of course.

getWindowScroll() function had some bugs.

  1. pageXOffset and pageYOffset properties not supported by IE 8 and earlier
  2. When you trying to get offset for node in iframe, getWindowScroll must return scroll inside iframe. Not for global window.

velocityzen avatar Feb 27 '13 09:02 velocityzen

hey @velocityzen, any chance you could think up some additional tests for these to demonstrate the original problem(s) so we don't get regressions in future?

rvagg avatar Apr 13 '13 04:04 rvagg

Yeah.

velocityzen avatar Apr 19 '13 08:04 velocityzen

how are we going on those tests @velocityzen, any brilliant ideas to be able to capture this as a test case?

rvagg avatar Oct 14 '13 04:10 rvagg

Hello. Don't have a time for this, sorry. Test case is simple. Just check element positioning inside iframe!

velocityzen avatar Oct 14 '13 08:10 velocityzen

will leave this open for now in case anyone else has time to add tests for this, otherwise it'll probably just be closed at some point in the future.

rvagg avatar Oct 14 '13 11:10 rvagg