bonzo icon indicating copy to clipboard operation
bonzo copied to clipboard

Perhaps we can now unexpose removeAttr from the API?

Open aawwawa opened this issue 12 years ago • 6 comments

Clean APIs are nice, right?

aawwawa avatar Nov 26 '12 00:11 aawwawa

Make for lighter docs, too...

aawwawa avatar Nov 26 '12 00:11 aawwawa

I'm fine with this too as long as we can have some tests (sorry for the 11 month delay on commenting!)

rvagg avatar Oct 14 '13 04:10 rvagg

removeAttr() should stay exposed for jQuery compatibility.

ryanve avatar Oct 14 '13 21:10 ryanve

good call @ryanve, I didn't know that was a jQuery thing.

rvagg avatar Oct 14 '13 22:10 rvagg

strange. so what needs to change or not change?

ded avatar Oct 15 '13 23:10 ded

i see. yes. if we keep it, then that is correct, we should just make it check for null

ded avatar Oct 15 '13 23:10 ded