pi-ui icon indicating copy to clipboard operation
pi-ui copied to clipboard

Published 20 hours ago • verified publisher icon decred

Create new Amount component

Open tiagoalvesdulce opened this issue 3 years ago • 8 comments

Screen Shot 2021-11-16 at 10 56 41

This new component can be a variation of NumberInput.

@MariaPleshkova @linnutee Questions:

  1. The button in the old Amount is responsible for filling the Amount with all the funds in the wallet. I think this is pretty useful for moving funds from default to unmixed, for example. How would something like that be accomplished with the new design?

  2. Can't we make the requested amount and amount the same?

tiagoalvesdulce avatar Nov 16 '21 14:11 tiagoalvesdulce

Yep I think so, amount picker is important enough to have a distinct field.

ta-lind avatar Nov 26 '21 16:11 ta-lind

Can I see the origin design @tiagoalvesdulce ?

vibros68 avatar Dec 17 '21 02:12 vibros68

I took this component from the figma master file here: https://github.com/decred/pi-ui/issues/323. This is more of a decrediton component so I think decrediton devs should handle it. I'll create labels to make this clear.

tiagoalvesdulce avatar Dec 17 '21 12:12 tiagoalvesdulce

@tiagoalvesdulce @alexlyp @bgptr I would like to work on this one if it's still in todo ?

amass01 avatar Sep 30 '22 10:09 amass01

If the decrediton devs think this component will still be useful, go for it!

tiagoalvesdulce avatar Sep 30 '22 12:09 tiagoalvesdulce

Sure, go for it!

bgptr avatar Sep 30 '22 14:09 bgptr

hrmmm looks like storybook doesn't work 💯 ATM, how do you test your pi-ui work guys ?

amass01 avatar Sep 30 '22 14:09 amass01

@amass01 sorry for the delay. I didn't get a notification somehow. Can you detail your issue? Storybook is working here just fine.

tiagoalvesdulce avatar Oct 19 '22 15:10 tiagoalvesdulce