dcrwallet icon indicating copy to clipboard operation
dcrwallet copied to clipboard

go test all

Open jrick opened this issue 7 years ago • 0 comments

Go modules make it simple to find what code is being imported into a project (go list -m all), why it is being imported (go mod why), and whether the combination of selected versions are compatible (go test all). We would obviously like go test all to always pass, especially before creating releases.

The following is the output of 'go test all' on a linux/amd64 machine, running Go 1.11 RC1:

$ go test all
?   	github.com/decred/dcrwallet	[no test files]
?   	github.com/decred/dcrwallet/cmd/movefunds	[no test files]
?   	github.com/decred/dcrwallet/cmd/sweepaccount	[no test files]
?   	github.com/decred/dcrwallet/internal/cfgutil	[no test files]
?   	github.com/decred/dcrwallet/internal/prompt	[no test files]
?   	github.com/decred/dcrwallet/internal/rpchelp	[no test files]
?   	github.com/decred/dcrwallet/loader	[no test files]
?   	github.com/decred/dcrwallet/netparams	[no test files]
?   	github.com/decred/dcrwallet/prompt	[no test files]
ok  	github.com/decred/dcrwallet/rpc/legacyrpc	(cached)
?   	github.com/decred/dcrwallet/rpc/rpcserver	[no test files]
?   	github.com/decred/dcrwallet/rpc/walletrpc	[no test files]
# gopkg.in/tomb.v1_test
../../go/pkg/mod/gopkg.in/[email protected]/tomb_test.go:42: T.Fatalf format %q reads arg #2, but call has 1 arg
Generating primary test harness
Node RPC client connected.
Wallet RPC client connected.
Node RPC client connected, miningaddr: Ssj6Amgc5fh6e1xt2zQWNcAm9R679sEkzf2.
Generating 41 blocks...
Block generation complete.
Waiting for wallet to sync to current height.
Wallet sync complete.
Generating own harness for testListTransactions
Unable to setup test chain:  connection timed out: x509: certificate signed by unknown authority (possibly because of "x509: ECDSA verification failure" while trying to verify candidate authority certificate "tower.i.zettaport.com")
FAIL	github.com/decred/dcrwallet/rpctest	67.898s
?   	github.com/decred/dcrwallet/rpctest/mkharness	[no test files]
ok  	bufio	(cached)
ok  	context	(cached)
ok  	crypto/tls	(cached)
ok  	encoding/binary	(cached)
ok  	fmt	(cached)
ok  	github.com/decred/dcrd/addrmgr	(cached)
ok  	github.com/decred/dcrd/certgen	(cached)
ok  	github.com/decred/dcrd/chaincfg	(cached)
ok  	github.com/decred/dcrd/connmgr	(cached)
ok  	github.com/decred/dcrd/dcrutil	(cached)
ok  	github.com/decred/dcrd/hdkeychain	(cached)
ok  	github.com/decred/dcrd/rpcclient	(cached)
ok  	github.com/decred/dcrd/wire	(cached)
?   	github.com/decred/dcrwallet/chain	[no test files]
ok  	github.com/decred/dcrwallet/errors	(cached)
ok  	github.com/decred/dcrwallet/internal/zero	(cached)
?   	github.com/decred/dcrwallet/p2p	[no test files]
?   	github.com/decred/dcrwallet/spv	[no test files]
?   	github.com/decred/dcrwallet/ticketbuyer	[no test files]
?   	github.com/decred/dcrwallet/ticketbuyer/v2	[no test files]
?   	github.com/decred/dcrwallet/version	[no test files]
ok  	github.com/decred/dcrwallet/wallet	(cached)
?   	github.com/decred/dcrwallet/wallet/drivers/bdb	[no test files]
ok  	github.com/decred/dcrwallet/wallet/txrules	(cached)
ok  	github.com/decred/dcrwallet/wallet/udb	(cached)
ok  	github.com/decred/dcrwallet/walletseed	(cached)
?   	github.com/decred/slog	[no test files]
ok  	github.com/jessevdk/go-flags	(cached)
?   	github.com/jrick/logrotate/rotator	[no test files]
2018/08/19 13:13:20 Error finding google.golang.org/grpc/testdata directory: file does not exist
FAIL	google.golang.org/grpc	13.919s
2018/08/19 13:13:06 Error finding google.golang.org/grpc/testdata directory: file does not exist
FAIL	google.golang.org/grpc/credentials	0.049s
?   	google.golang.org/grpc/peer	[no test files]
ok  	io	(cached)
ok  	io/ioutil	(cached)
ok  	net	(cached)
ok  	net/http	(cached)
ok  	net/http/pprof	(cached)
--- FAIL: TestMkdirAllAtSlash (0.00s)
    path_test.go:250: MkdirAll "/_go_os_test/dir": mkdir /_go_os_test: operation not permitted, operation not permitted
FAIL
FAIL	os	18.456s
ok  	os/signal	(cached)
ok  	os/user	(cached)
ok  	path/filepath	(cached)
ok  	runtime	(cached)
ok  	runtime/pprof	(cached)
ok  	sort	(cached)
ok  	strings	(cached)
ok  	syscall	(cached)
ok  	time	(cached)
ok  	bytes	(cached)
ok  	encoding/hex	(cached)
ok  	encoding/json	(cached)
ok  	github.com/decred/dcrd/chaincfg/chainhash	(cached)
ok  	github.com/decred/dcrd/dcrjson	(cached)
ok  	github.com/decred/dcrd/txscript	(cached)
ok  	math	(cached)
ok  	github.com/decred/dcrwallet/wallet/txauthor	(cached)
ok  	golang.org/x/crypto/ssh/terminal	(cached)
ok  	crypto/elliptic	(cached)
ok  	strconv	(cached)
ok  	unicode	(cached)
ok  	sync	(cached)
ok  	crypto/sha256	(cached)
ok  	crypto/subtle	(cached)
ok  	encoding/base64	(cached)
ok  	github.com/btcsuite/websocket	(cached)
ok  	github.com/decred/dcrd/blockchain	17.082s
ok  	github.com/decred/dcrd/blockchain/stake	(cached)
?   	github.com/decred/dcrd/dcrec	[no test files]
?   	github.com/decred/dcrwallet/internal/helpers	[no test files]
ok  	math/big	(cached)
ok  	sync/atomic	(cached)
ok  	crypto/rand	(cached)
ok  	google.golang.org/grpc/codes	(cached)
ok  	google.golang.org/grpc/grpclog	(cached)
ok  	google.golang.org/grpc/status	(cached)
ok  	github.com/golang/protobuf/proto	(cached)
ok  	golang.org/x/net/context	(cached)
ok  	log	(cached)
ok  	os/exec	(cached)
ok  	errors	(cached)
ok  	unicode/utf8	(cached)
ok  	reflect	(cached)
ok  	container/list	(cached)
ok  	crypto	(cached)
ok  	crypto/aes	(cached)
ok  	crypto/cipher	(cached)
ok  	crypto/des	(cached)
ok  	crypto/ecdsa	(cached)
ok  	crypto/hmac	(cached)
ok  	crypto/md5	(cached)
ok  	crypto/rc4	(cached)
ok  	crypto/rsa	(cached)
ok  	crypto/sha1	(cached)
ok  	crypto/sha512	(cached)
ok  	crypto/x509	(cached)
ok  	encoding/asn1	(cached)
ok  	encoding/pem	(cached)
ok  	golang_org/x/crypto/chacha20poly1305	(cached)
ok  	golang_org/x/crypto/curve25519	(cached)
ok  	hash	(cached)
ok  	internal/cpu	(cached)
ok  	encoding/base32	(cached)
ok  	math/rand	(cached)
?   	crypto/x509/pkix	[no test files]
ok  	github.com/decred/base58	(cached)
ok  	github.com/decred/dcrd/chaincfg/chainec	(cached)
ok  	github.com/decred/dcrd/dcrec/edwards	(cached)
ok  	github.com/decred/dcrd/dcrec/secp256k1	(cached)
ok  	github.com/decred/dcrd/dcrec/secp256k1/schnorr	(cached)
ok  	golang.org/x/crypto/ripemd160	(cached)
?   	github.com/btcsuite/go-socks/socks	[no test files]
ok  	github.com/decred/dcrd/gcs	(cached)
?   	github.com/decred/dcrd/gcs/blockcf	[no test files]
ok  	github.com/gorilla/websocket	(cached)
ok  	net/url	(cached)
ok  	golang.org/x/sync/errgroup	(cached)
ok  	runtime/debug	(cached)
?   	github.com/decred/dcrwallet/lru	[no test files]
?   	github.com/decred/dcrwallet/validate	[no test files]
ok  	github.com/decred/dcrd/mempool	(cached)
?   	github.com/decred/dcrwallet/deployments	[no test files]
ok  	github.com/decred/dcrwallet/wallet/internal/txsizes	(cached)
ok  	github.com/decred/dcrwallet/wallet/internal/walletdb	(cached)
ok  	github.com/jrick/bitset	(cached)
?   	github.com/decred/dcrwallet/wallet/internal/walletdb/bdb	[no test files]
ok  	github.com/decred/dcrwallet/wallet/internal/snacl	(cached)
ok  	github.com/decred/dcrwallet/pgpwordlist	(cached)
ok  	path	(cached)
?   	unsafe	[no test files]
ok  	compress/gzip	(cached)
ok  	golang.org/x/net/http2	(cached)
ok  	golang.org/x/net/trace	(cached)
?   	google.golang.org/grpc/balancer	[no test files]
ok  	google.golang.org/grpc/balancer/roundrobin	0.362s
?   	google.golang.org/grpc/connectivity	[no test files]
?   	google.golang.org/grpc/encoding	[no test files]
ok  	google.golang.org/grpc/encoding/proto	(cached)
?   	google.golang.org/grpc/internal	[no test files]
?   	google.golang.org/grpc/internal/backoff	[no test files]
ok  	google.golang.org/grpc/internal/channelz	(cached)
?   	google.golang.org/grpc/internal/envconfig	[no test files]
?   	google.golang.org/grpc/internal/grpcrand	[no test files]
ok  	google.golang.org/grpc/internal/transport	(cached)
?   	google.golang.org/grpc/keepalive	[no test files]
ok  	google.golang.org/grpc/metadata	(cached)
ok  	google.golang.org/grpc/naming	(cached)
?   	google.golang.org/grpc/resolver	[no test files]
ok  	google.golang.org/grpc/resolver/dns	(cached)
?   	google.golang.org/grpc/resolver/passthrough	[no test files]
ok  	google.golang.org/grpc/stats	(cached)
?   	google.golang.org/grpc/tap	[no test files]
ok  	net/http/httputil	(cached)
ok  	golang_org/x/net/dns/dnsmessage	(cached)
?   	internal/nettrace	[no test files]
ok  	internal/poll	(cached)
ok  	internal/singleflight	(cached)
ok  	golang_org/x/net/http/httpguts	(cached)
ok  	golang_org/x/net/http/httpproxy	(cached)
ok  	golang_org/x/net/http2/hpack	(cached)
ok  	golang_org/x/net/idna	(cached)
ok  	mime	(cached)
ok  	mime/multipart	(cached)
ok  	net/http/httptrace	(cached)
ok  	net/http/internal	(cached)
ok  	net/textproto	(cached)
ok  	html/template	(cached)
ok  	runtime/trace	(cached)
?   	internal/syscall/unix	[no test files]
?   	internal/testlog	[no test files]
?   	internal/bytealg	[no test files]
ok  	runtime/internal/atomic	(cached)
ok  	runtime/internal/sys	(cached)
ok  	text/tabwriter	(cached)
?   	internal/race	[no test files]
?   	encoding	[no test files]
ok  	unicode/utf16	(cached)
ok  	github.com/dchest/blake256	(cached)
--- FAIL: TestPpoll (0.00s)
    syscall_unix_test.go:610: mktmpfifo: failed to create FIFO: permission denied
--- FAIL: TestPoll (0.00s)
    syscall_unix_test.go:610: mktmpfifo: failed to create FIFO: permission denied
FAIL
FAIL	golang.org/x/sys/unix	0.212s
ok  	math/bits	(cached)
?   	github.com/decred/dcrd/blockchain/internal/dbnamespace	[no test files]
?   	github.com/decred/dcrd/blockchain/internal/progresslog	[no test files]
ok  	github.com/decred/dcrd/database	0.103s
?   	github.com/decred/dcrd/blockchain/stake/internal/dbnamespace	[no test files]
ok  	github.com/decred/dcrd/blockchain/stake/internal/ticketdb	(cached)
ok  	github.com/decred/dcrd/blockchain/stake/internal/tickettreap	(cached)
ok  	net/http/httptest	(cached)
ok  	testing	(cached)
ok  	github.com/golang/protobuf/ptypes	(cached)
?   	google.golang.org/genproto/googleapis/rpc/status	[no test files]
ok  	flag	(cached)
ok  	regexp	(cached)
?   	testing/iotest	[no test files]
ok  	crypto/internal/subtle	(cached)
?   	crypto/internal/randutil	[no test files]
ok  	crypto/dsa	(cached)
ok  	golang_org/x/crypto/cryptobyte	(cached)
?   	golang_org/x/crypto/cryptobyte/asn1	[no test files]
ok  	golang_org/x/crypto/internal/chacha20	(cached)
ok  	golang_org/x/crypto/poly1305	(cached)
?   	internal/testenv	[no test files]
ok  	testing/quick	(cached)
ok  	github.com/davecgh/go-spew/spew	(cached)
ok  	github.com/agl/ed25519	(cached)
?   	github.com/agl/ed25519/edwards25519	[no test files]
ok  	compress/zlib	(cached)
ok  	github.com/dchest/siphash	(cached)
ok  	compress/flate	(cached)
ok  	github.com/decred/dcrd/blockchain/indexers	(cached)
?   	github.com/decred/dcrd/mining	[no test files]
ok  	github.com/decred/dcrd/blockchain/chaingen	(cached)
ok  	github.com/boltdb/bolt	81.540s
ok  	golang.org/x/crypto/nacl/secretbox	(cached)
ok  	golang.org/x/crypto/scrypt	(cached)
ok  	hash/crc32	(cached)
ok  	golang.org/x/net/http/httpguts	(cached)
ok  	golang.org/x/net/http2/hpack	(cached)
ok  	golang.org/x/net/idna	(cached)
ok  	golang.org/x/net/internal/timeseries	(cached)
?   	google.golang.org/grpc/balancer/base	[no test files]
?   	google.golang.org/grpc/grpclog/glogger	[no test files]
ok  	google.golang.org/grpc/internal/leakcheck	(cached)
?   	google.golang.org/grpc/resolver/manual	[no test files]
?   	google.golang.org/grpc/test/codec_perf	[no test files]
?   	google.golang.org/grpc/testdata	[no test files]
ok  	golang_org/x/net/nettest	(cached)
ok  	net/internal/socktest	(cached)
?   	golang_org/x/text/secure/bidirule	[no test files]
?   	golang_org/x/text/unicode/bidi	[no test files]
ok  	golang_org/x/text/unicode/norm	(cached)
ok  	mime/quotedprintable	(cached)
ok  	go/ast	(cached)
ok  	net/http/cookiejar	(cached)
ok  	html	(cached)
ok  	text/template	(cached)
ok  	text/template/parse	(cached)
?   	os/signal/internal/pty	[no test files]
ok  	go/build	0.097s
ok  	math/cmplx	(cached)
ok  	runtime/pprof/internal/profile	(cached)
ok  	encoding/gob	(cached)
ok  	image	(cached)
ok  	compress/bzip2	(cached)
?   	github.com/decred/dcrd/blockchain/fullblocktests	[no test files]
ok  	github.com/decred/dcrd/database/ffldb	1.870s
ok  	encoding/xml	(cached)
?   	google.golang.org/genproto/googleapis/rpc/code	[no test files]
?   	github.com/golang/protobuf/ptypes/any	[no test files]
?   	github.com/golang/protobuf/ptypes/duration	[no test files]
?   	github.com/golang/protobuf/ptypes/timestamp	[no test files]
?   	google.golang.org/genproto/googleapis/rpc/errdetails	[no test files]
?   	github.com/golang/protobuf/proto/proto3_proto	[no test files]
?   	github.com/golang/protobuf/proto/test_proto	[no test files]
ok  	regexp/syntax	(cached)
ok  	go/token	(cached)
ok  	hash/adler32	(cached)
ok  	hash/crc64	(cached)
ok  	hash/fnv	(cached)
ok  	golang.org/x/crypto/internal/subtle	(cached)
ok  	golang.org/x/crypto/poly1305	(cached)
ok  	golang.org/x/crypto/salsa20/salsa	(cached)
ok  	golang.org/x/crypto/pbkdf2	(cached)
ok  	golang.org/x/text/secure/bidirule	(cached)
ok  	golang.org/x/text/unicode/bidi	(cached)
ok  	golang.org/x/text/unicode/norm	(cached)
?   	google.golang.org/grpc/test/grpc_testing	[no test files]
?   	google.golang.org/grpc/stats/grpc_testing	[no test files]
ok  	github.com/golang/glog	1.020s
ok  	golang_org/x/text/transform	(cached)
ok  	net/mail	(cached)
ok  	go/scanner	(cached)
ok  	internal/trace	(cached)
ok  	go/doc	(cached)
ok  	go/parser	(cached)
ok  	image/color	(cached)
ok  	github.com/btcsuite/goleveldb/leveldb	74.063s
?   	github.com/btcsuite/goleveldb/leveldb/comparer	[no test files]
?   	github.com/btcsuite/goleveldb/leveldb/errors	[no test files]
ok  	github.com/btcsuite/goleveldb/leveldb/filter	(cached)
ok  	github.com/btcsuite/goleveldb/leveldb/iterator	(cached)
?   	github.com/btcsuite/goleveldb/leveldb/opt	[no test files]
ok  	github.com/btcsuite/goleveldb/leveldb/util	(cached)
ok  	github.com/decred/dcrd/database/internal/treap	(cached)
?   	github.com/golang/protobuf/protoc-gen-go/descriptor	[no test files]
ok  	golang.org/x/text/transform	(cached)
?   	golang_org/x/net/internal/nettest	[no test files]
ok  	go/format	(cached)
ok  	image/gif	(cached)
ok  	image/jpeg	(cached)
ok  	image/png	(cached)
ok  	github.com/btcsuite/goleveldb/leveldb/cache	(cached)
ok  	github.com/btcsuite/goleveldb/leveldb/journal	(cached)
ok  	github.com/btcsuite/goleveldb/leveldb/memdb	(cached)
ok  	github.com/btcsuite/goleveldb/leveldb/storage	(cached)
ok  	github.com/btcsuite/goleveldb/leveldb/table	(cached)
?   	golang.org/x/text/internal/testtext	[no test files]
?   	golang.org/x/text/internal/gen	[no test files]
ok  	golang.org/x/text/internal/ucd	(cached)
ok  	golang.org/x/text/unicode/rangetable	(cached)
ok  	go/printer	(cached)
ok  	compress/lzw	(cached)
?   	image/color/palette	[no test files]
ok  	image/draw	(cached)
?   	image/internal/imageutil	[no test files]
ok  	github.com/btcsuite/snappy-go	(cached)
?   	github.com/btcsuite/goleveldb/leveldb/testutil	[no test files]
?   	github.com/onsi/ginkgo	[no test files]
?   	github.com/onsi/gomega	[no test files]
ok  	golang.org/x/text/unicode/cldr	(cached)
?   	github.com/onsi/ginkgo/config	[no test files]
ok  	github.com/onsi/ginkgo/internal/codelocation	(cached)
ok  	github.com/onsi/ginkgo/internal/failer	(cached)
ok  	github.com/onsi/ginkgo/internal/remote	(cached)
ok  	github.com/onsi/ginkgo/internal/suite	(cached)
?   	github.com/onsi/ginkgo/internal/testingtproxy	[no test files]
ok  	github.com/onsi/ginkgo/internal/writer	(cached)
ok  	github.com/onsi/ginkgo/reporters	(cached)
?   	github.com/onsi/ginkgo/reporters/stenographer	[no test files]
?   	github.com/onsi/ginkgo/reporters/stenographer/support/go-colorable	[no test files]
ok  	github.com/onsi/ginkgo/types	(cached)
ok  	github.com/onsi/gomega/internal/assertion	(cached)
ok  	github.com/onsi/gomega/internal/asyncassertion	(cached)
ok  	github.com/onsi/gomega/internal/testingtsupport	(cached)
ok  	github.com/onsi/gomega/matchers	(cached)
?   	github.com/onsi/gomega/types	[no test files]
ok  	archive/zip	(cached)
2018/08/19 13:13:08 Waiting for /no/such/file to appear...
--- FAIL: TestWaitsForFileToExist (0.00s)
    tail_test.go:416: mkdir .test: permission denied
--- FAIL: TestWaitsForFileToExistRelativePath (0.00s)
    tail_test.go:416: mkdir .test: permission denied
2018/08/19 13:13:08 Waiting for _no_such_file to appear...
--- FAIL: TestStopAtEOF (0.00s)
    tail_test.go:416: mkdir .test: permission denied
--- FAIL: TestMaxLineSizeFollow (0.00s)
    tail_test.go:416: mkdir .test: permission denied
--- FAIL: TestMaxLineSizeNoFollow (0.00s)
    tail_test.go:416: mkdir .test: permission denied
--- FAIL: TestOver4096ByteLine (0.00s)
    tail_test.go:416: mkdir .test: permission denied
--- FAIL: TestOver4096ByteLineWithSetMaxLineSize (0.00s)
    tail_test.go:416: mkdir .test: permission denied
--- FAIL: TestLocationFull (0.00s)
    tail_test.go:416: mkdir .test: permission denied
--- FAIL: TestLocationFullDontFollow (0.00s)
    tail_test.go:416: mkdir .test: permission denied
--- FAIL: TestLocationEnd (0.00s)
    tail_test.go:416: mkdir .test: permission denied
--- FAIL: TestLocationMiddle (0.00s)
    tail_test.go:416: mkdir .test: permission denied
--- FAIL: TestReOpenInotify (0.00s)
    tail_test.go:416: mkdir .test: permission denied
--- FAIL: TestReOpenPolling (0.00s)
    tail_test.go:416: mkdir .test: permission denied
--- FAIL: TestReSeekInotify (0.00s)
    tail_test.go:416: mkdir .test: permission denied
--- FAIL: TestReSeekPolling (0.00s)
    tail_test.go:416: mkdir .test: permission denied
--- FAIL: TestRateLimiting (0.00s)
    tail_test.go:416: mkdir .test: permission denied
--- FAIL: TestTell (0.00s)
    tail_test.go:416: mkdir .test: permission denied
--- FAIL: TestBlockUntilExists (0.00s)
    tail_test.go:416: mkdir .test: permission denied
FAIL
FAIL	github.com/hpcloud/tail	0.006s
ok  	github.com/onsi/ginkgo/internal/spec_iterator	(cached)
ok  	github.com/onsi/ginkgo/internal/containernode	(cached)
ok  	github.com/onsi/ginkgo/internal/leafnodes	(cached)
ok  	github.com/onsi/ginkgo/internal/spec	(cached)
ok  	github.com/onsi/ginkgo/internal/specrunner	(cached)
?   	github.com/onsi/gomega/internal/oraclematcher	[no test files]
ok  	github.com/onsi/gomega/format	(cached)
?   	github.com/onsi/gomega/matchers/support/goraph/bipartitegraph	[no test files]
ok  	golang.org/x/net/html/charset	(cached)
ok  	gopkg.in/yaml.v2	(cached)
ok  	github.com/hpcloud/tail/ratelimiter	(cached)
?   	github.com/hpcloud/tail/util	[no test files]
?   	github.com/hpcloud/tail/watch	[no test files]
FAIL	gopkg.in/tomb.v1 [build failed]
ok  	github.com/onsi/gomega/gbytes	(cached)
?   	github.com/onsi/gomega/internal/fakematcher	[no test files]
?   	github.com/onsi/gomega/matchers/support/goraph/edge	[no test files]
?   	github.com/onsi/gomega/matchers/support/goraph/node	[no test files]
?   	github.com/onsi/gomega/matchers/support/goraph/util	[no test files]
ok  	golang.org/x/net/html	(cached)
ok  	golang.org/x/text/encoding	(cached)
ok  	golang.org/x/text/encoding/charmap	(cached)
ok  	golang.org/x/text/encoding/htmlindex	(cached)
ok  	gopkg.in/fsnotify.v1	(cached)
ok  	github.com/onsi/gomega/ghttp	(cached)
ok  	golang.org/x/net/html/atom	(cached)
?   	golang.org/x/text/encoding/internal/identifier	[no test files]
?   	golang.org/x/text/encoding/internal	[no test files]
ok  	golang.org/x/text/encoding/japanese	(cached)
ok  	golang.org/x/text/encoding/korean	(cached)
ok  	golang.org/x/text/encoding/simplifiedchinese	(cached)
ok  	golang.org/x/text/encoding/traditionalchinese	(cached)
ok  	golang.org/x/text/encoding/unicode	(cached)
ok  	golang.org/x/text/language	(cached)
ok  	gopkg.in/check.v1	(cached)
?   	golang.org/x/text/encoding/internal/enctest	[no test files]
?   	golang.org/x/text/internal/utf8internal	[no test files]
ok  	golang.org/x/text/runes	(cached)
ok  	golang.org/x/text/internal/tag	(cached)
ok  	github.com/kr/pretty	(cached)
ok  	github.com/fsnotify/fsnotify	(cached)
?   	github.com/onsi/gomega/ghttp/protobuf	[no test files]
ok  	github.com/kr/text	(cached)
ok  	golang.org/x/text/cases	(cached)
ok  	golang.org/x/text/width	(cached)
ok  	golang.org/x/text/internal	(cached)

Excluding the failures in the standard library, the following packages currently fail tests:

  • github.com/decred/dcrwallet/rpctest
  • google.golang.org/grpc
  • google.golang.org/grpc/credentials
  • github.com/hpcloud/tail
  • gopkg.in/tomb.v1

github.com/decred/dcrwallet/rpctest is our own test, so we need to just fix this. It's not run on CI as it is disabled with -short.

google.golang.org/grpc and google.golang.org/grpc/credentials fail looking up testdata directories relative to a user's GOPATH. We experienced similar issues with relative testdata paths in dcrd, so it appears that gRPC will need to rearchitect their tests for this to pass when built as a module.

I didn't know what github.com/hpcloud/tail or gopkg.in/tomb.v1 were, why they were imported, or what they did, prior to seeing them fail tests. tomb fails due to a bad format string caught by vet (now run as part of go test), and tail fails as it tries to create files in its own package directory (this fails when the module is tested as part of a larger build as the module directory and all files are read only).

Both tail and tomb are only being imported due to being required by the blockchain and leveldb modules:

$ go mod why github.com/hpcloud/tail
# github.com/hpcloud/tail
github.com/decred/dcrwallet/rpc/legacyrpc
github.com/decred/dcrd/blockchain
github.com/decred/dcrd/blockchain.test
github.com/decred/dcrd/database/ffldb
github.com/btcsuite/goleveldb/leveldb
github.com/btcsuite/goleveldb/leveldb.test
github.com/onsi/ginkgo
github.com/onsi/ginkgo/internal/remote
github.com/hpcloud/tail
$ go mod why gopkg.in/tomb.v1
# gopkg.in/tomb.v1
github.com/decred/dcrwallet/rpc/legacyrpc
github.com/decred/dcrd/blockchain
github.com/decred/dcrd/blockchain.test
github.com/decred/dcrd/database/ffldb
github.com/btcsuite/goleveldb/leveldb
github.com/btcsuite/goleveldb/leveldb.test
github.com/onsi/ginkgo
github.com/onsi/ginkgo/internal/remote
github.com/hpcloud/tail
gopkg.in/tomb.v1

It would be better to reorganize the packages in dcrd so that all blockchain functions used by the wallet can still be imported without also creating a transitive dependency on leveldb. This would remove several different third party modules from the wallet build.

jrick avatar Aug 19 '18 17:08 jrick