dcrdex icon indicating copy to clipboard operation
dcrdex copied to clipboard

client: Babysit refund transactions.

Open JoeGruffins opened this issue 1 year ago • 13 comments

core: Confirm refund txs.

client/asset: Add confirm tx.

client/db: Upgrade to version seven.

closes #3063

JoeGruffins avatar Nov 17 '24 09:11 JoeGruffins

Looks good!

dev-warrior777 avatar Nov 26 '24 10:11 dev-warrior777

marton review fixes https://github.com/decred/dcrdex/compare/5a4b56a74a5394c0113ce543491fb24fecf05761..358a1bb86d500748e189738b2808244a3618e1e6

JoeGruffins avatar Nov 29 '24 09:11 JoeGruffins

@martonp Sorry I didnt rebase before pushing changes. The first point is probably fixed by the change in trade.go here https://github.com/decred/dcrdex/compare/358a1bb86d500748e189738b2808244a3618e1e6..39ee55b05b201f3c2d85c9558ed8624c1bd56e6c

I tried testing the replace transactions but I'm not sure if I'm blocking something bisonw needs for popups... I'll try some more.

JoeGruffins avatar Dec 01 '24 07:12 JoeGruffins

Oh yeah, I'm only seeing the popup after restarting. hmmm...

JoeGruffins avatar Dec 04 '24 08:12 JoeGruffins

@martonp it is based on this timeout for a running instance https://github.com/decred/dcrdex/blob/0030e49e0aa4159f2b55eee546c9083a51146c1e/client/asset/eth/eth.go#L108-L110

The tx should become stale and you will see the popup after that interval. You can reduce it ofc to check.

JoeGruffins avatar Dec 05 '24 02:12 JoeGruffins

Adding refundRejected to js switch https://github.com/decred/dcrdex/compare/2eedfb3da5ea45204465d030c8fa63274c536489..aef18891dd3d51ffc43a56a16479c674bc0d8275

JoeGruffins avatar Dec 09 '24 07:12 JoeGruffins

It's asking me twice now to replace. Something is off.

JoeGruffins avatar Dec 16 '24 09:12 JoeGruffins

transactions fail (status of transaction in receipt is 1).

Failure is 0x00 status I think?

JoeGruffins avatar Dec 17 '24 08:12 JoeGruffins

This should fix the issue: 8d03288d6a441a69e606782a97d31556f12ab7ce

martonp avatar Dec 23 '24 18:12 martonp

Trying with the new harness changes and the thing mines a block if there is any transaction without telling it to. So, unable to get the replacement transaction in now.

JoeGruffins avatar Dec 24 '24 09:12 JoeGruffins

Fixing nonce error, but hard to test for me now https://github.com/decred/dcrdex/compare/15ae0091376ae4ea1d539f735778ea09fad51159..9c5d74bab7ceb582f6f12772a83458241c9d2204

JoeGruffins avatar Dec 24 '24 09:12 JoeGruffins

Found a few more bugs, fixed with this: 6aea35edcf58092a23af9ad8495425fc4eac9b03

martonp avatar Jan 04 '25 17:01 martonp

Thanks @martonp added the commit.

JoeGruffins avatar Jan 06 '25 03:01 JoeGruffins

Was a hairy rebase, need to retest

JoeGruffins avatar Aug 14 '25 06:08 JoeGruffins

Just rebased.

JoeGruffins avatar Nov 12 '25 07:11 JoeGruffins

Made the confirm tx types the correct type base and renamed requiredConfTxConfirms -> confTxFinality https://github.com/decred/dcrdex/compare/dc9fb240e7a02988799248f5d7f004d78301a5c8..7a82102818d7b3f9eb637853ff5d03959585c09d

JoeGruffins avatar Dec 01 '25 04:12 JoeGruffins