dcrdex icon indicating copy to clipboard operation
dcrdex copied to clipboard

mm: binance is reporting dcr balance as available before required confs

Open buck54321 opened this issue 1 year ago • 4 comments

There was a report that Binance was reporting some deposited balance as available before it had the required number of confs. We should investigate this and figure out the implications for UI and inventory transfers.

buck54321 avatar Sep 11 '24 15:09 buck54321

Just to add, it's showing 1 Pending Deposit which is correct. However, the balance is not quite there yet. IMG_20240911_231957_1

gravityz3r0 avatar Sep 11 '24 15:09 gravityz3r0

Oooh. Maybe this is OK then. We have to account for that balance somewhere, or else users will think it's just gone. We could break out an "unconfirmed" balance section in the UI I guess. I'll leave this issue open for discussion.

buck54321 avatar Sep 11 '24 15:09 buck54321

Oooh. Maybe this is OK then. We have to account for that balance somewhere, or else users will think it's just gone. We could break out an "unconfirmed" balance section in the UI I guess. I'll leave this issue open for discussion.

My concern was that, bot might misbehave because it's "seeing a balance" that's not supposed to be there yet. The funds are not ready to trade, and if it tried to place an order on Binance, it will fail. Unless it somehow is able to differentiate between confirmed and pending confirmation balances.

gravityz3r0 avatar Sep 11 '24 15:09 gravityz3r0

We do differentiate behind the scenes.

buck54321 avatar Sep 11 '24 16:09 buck54321