dcrdex icon indicating copy to clipboard operation
dcrdex copied to clipboard

Published 20 hours ago • verified publisher icon decred

dcr: Allow ticket purchasing for rpc spv wallets.

Open JoeGruffins opened this issue 1 year ago • 8 comments

The biggest blocker for this is that currently the GetTickets rpc call will not work over rpc with an spv wallet. That will need to be "fixed" over in dcrwallet. The second problem is that, if a vsp is not set, purchasing will fail, and we currently have no way to know if an ~spv~ vsp is set. If it's ok to just fail sometimes, maybe with a message asking the user to make sure a vsp is set, then maybe that's fine. Maybe we can also add some data to GetTickets or a new command to see if a vsp is currently set.

JoeGruffins avatar Nov 21 '23 02:11 JoeGruffins

Maybe we can also add some data to GetTickets or a new command to see if a vsp is currently set.

Maybe add a field to the walletinfo response?

buck54321 avatar Nov 21 '23 11:11 buck54321

Maybe add a field to the walletinfo response?

I think this is what I initially suggested to @jrick but maybe we can now.

JoeGruffins avatar Nov 21 '23 12:11 JoeGruffins

just opened decred/dcrwallet#2305 which adds the result to getinfo.

But also now I'm seeing that a similar field was already added to walletinfo, so I'm not sure if this is even needed (a "spv" field is set to true if it's currently syncing with the spv syncer).

jrick avatar Nov 22 '23 16:11 jrick

The second problem is that, if a vsp is not set, purchasing will fail, and we currently have no way to know if an spv is set

ah, this typo threw me off (spv instead of vsp...).

Gonna close the above pr then since the issue is only about detecting vsp settings, afaict.

jrick avatar Nov 22 '23 16:11 jrick

decred/dcrwallet#2306

jrick avatar Nov 22 '23 17:11 jrick

ah, this typo threw me off (spv instead of vsp...).

srry... I do that a lot.

JoeGruffins avatar Nov 24 '23 02:11 JoeGruffins

The biggest blocker for this is that currently the GetTickets rpc call will not work over rpc with an spv wallet.

https://github.com/decred/dcrwallet/pull/2321

buck54321 avatar Jan 05 '24 12:01 buck54321

@buck54321 I guess we need to use master to have those changes? I attempted to use master with the simnet harness but https://github.com/decred/dcrwallet/pull/2340 is causing wallet sync to stop.

JoeGruffins avatar Apr 30 '24 08:04 JoeGruffins

@JoeGruffins dcrwallet has a 2.0.0 release now. Can you update the dep here?

buck54321 avatar May 23 '24 17:05 buck54321

@buck54321 it looks like all of the vsp fee processing logic has been removed from the vspd repo and is internal to wallet again.

https://github.com/decred/dcrwallet/issues/2033

JoeGruffins avatar May 24 '24 06:05 JoeGruffins