dcrdex icon indicating copy to clipboard operation
dcrdex copied to clipboard

Published 20 hours ago • verified publisher icon decred

client/asset/dcr: Switch to standalone.CheckTransactionSanity when updated module released.

Open davecgh opened this issue 2 years ago • 3 comments

The following will need to be updated once a new version of the blockchain/standalone module is released since the blockchain package will eventually be moving internal.

https://github.com/decred/dcrdex/blob/efd7c12e4caaadcb0e5f9266eb9fddb8e505f758/client/asset/dcr/dcr.go#L1861

- err = blockchain.CheckTransactionSanity(contractTx, dcr.chainParams) 
+ err = standalone.CheckTransactionSanity(contractTx, dcr.chainParams.MaxTxSize)

davecgh avatar May 14 '22 00:05 davecgh

Looks like we're still using blockchain.CheckTransactionSanity in one place on the client. Is this OK?

buck54321 avatar Nov 03 '23 00:11 buck54321

The function was removed as of blockchain/v5 and instead moved to standalone/v2.

It should be updated as suggested to use the latest code.

davecgh avatar Nov 03 '23 00:11 davecgh

It should be updated as suggested to use the latest code.

This change is in place: https://github.com/decred/dcrdex/blob/3cd3679e8177c5a85a1b8ca24d804f29475132f8/client/asset/dcr/dcr.go#L3266

https://github.com/decred/dcrdex/blob/3cd3679e8177c5a85a1b8ca24d804f29475132f8/client/asset/dcr/dcr.go#L38

peterzen avatar Jan 23 '24 21:01 peterzen